Page MenuHomePhabricator

FlaggedRevsComponent
ActivePublic

Members (6)

Watchers (12)

Details

Description

Allows for article content management by "editor" and "reviewer" classes (Homepage)

Recent Activity

Fri, May 23

Jdlrobson-WMF triaged T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki as Low priority.
Fri, May 23, 11:31 PM · FlaggedRevs, Electron-PDFs, Proton, Collection
Jdlrobson-WMF moved T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki from Backlog to Triaged (PHP) on the Collection board.
Fri, May 23, 11:29 PM · FlaggedRevs, Electron-PDFs, Proton, Collection
Jdlrobson-WMF changed the status of T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki from Open to Stalled.
Fri, May 23, 11:29 PM · FlaggedRevs, Electron-PDFs, Proton, Collection
Jdlrobson-WMF added a comment to T370740: "Download as PDF" button links to Special:Book instead of Special:DownloadAsPdf on dewiki.

I can't replicate this issue.

Fri, May 23, 11:29 PM · FlaggedRevs, Electron-PDFs, Proton, Collection

Thu, May 22

Ladsgroup placed T323495: flaggedrevs_statistics is holding millions of rows while FR needs only a handful up for grabs.

un-licking the cookie.

Thu, May 22, 11:53 AM · MW-1.44-notes (1.44.0-wmf.14; 2025-01-28), DBA, FlaggedRevs

Wed, May 21

cscott closed T391788: Parser limit reporting doesn't work on FlaggedRevs pages as Resolved.

Verified that limit report appears on https://de.wikipedia.org/wiki/Johanne_Karoline_Wilhelmine_Spazier

Wed, May 21, 4:57 PM · Content-Transform-Team (Work In Progress), MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), FlaggedRevs

Tue, May 20

mszabo moved T331643: MediaWiki\Page\PageAssertionException: The given PageIdentity {pageIdentity} does not represent a proper page from Mar 2023 to Sep 2022 on the Wikimedia-production-error board.
Tue, May 20, 11:02 PM · Unstewarded-production-error, FlaggedRevs, MediaWiki-Page-derived-data, Wikimedia-production-error
HCoplin-WMF edited projects for T198297: Use PageUpdater to create dummy revisions, added: MW-Interfaces-Team (MW-Sprint-10 (2025-05-20 to 2025-06-03)); removed MW-Interfaces-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)).
Tue, May 20, 3:09 PM · MW-Interfaces-Team (MW-Sprint-10 (2025-05-20 to 2025-06-03)), FlaggedRevs, MediaWiki-extensions-Translate, Move-Files-To-Commons, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-DomainEvents, Patch-For-Review
HCoplin-WMF assigned T198297: Use PageUpdater to create dummy revisions to daniel.
Tue, May 20, 3:05 PM · MW-Interfaces-Team (MW-Sprint-10 (2025-05-20 to 2025-06-03)), FlaggedRevs, MediaWiki-extensions-Translate, Move-Files-To-Commons, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-DomainEvents, Patch-For-Review
HCoplin-WMF moved T198297: Use PageUpdater to create dummy revisions from Committed to Code Review on the MW-Interfaces-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)) board.
Tue, May 20, 3:05 PM · MW-Interfaces-Team (MW-Sprint-10 (2025-05-20 to 2025-06-03)), FlaggedRevs, MediaWiki-extensions-Translate, Move-Files-To-Commons, MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-DomainEvents, Patch-For-Review
ReleaseTaggerBot edited projects for T394381: Error: Call to a member function getId() on null, added: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).
Tue, May 20, 2:00 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Maintenance_bot removed a project from T394381: Error: Call to a member function getId() on null: Patch-For-Review.
Tue, May 20, 1:30 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394381: Error: Call to a member function getId() on null.

Change #1147804 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add comments

https://gerrit.wikimedia.org/r/1147804

Tue, May 20, 1:22 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
PatchDemoBot added a comment to T349793: Replace legacy breakpoint value tokens in all Wikimedia web codebases.

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

Tue, May 20, 12:12 PM · MW-1.43-notes (1.43.0-wmf.26; 2024-10-08), MobileFrontend, RelatedArticles, MediaWiki-extensions-WikimediaEvents, wikimedia-page-library, FlaggedRevs, CSS, MediaWiki-General, MinervaNeue, Vector 2022 (Desktop improvements), Design-System-Team, Codex

Mon, May 19

gerritbot added a project to T394381: Error: Call to a member function getId() on null: Patch-For-Review.
Mon, May 19, 3:49 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394381: Error: Call to a member function getId() on null.

Change #1147804 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add comments

https://gerrit.wikimedia.org/r/1147804

Mon, May 19, 3:49 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Novem_Linguae added a member for FlaggedRevs: Novem_Linguae.
Mon, May 19, 3:39 PM

Sat, May 17

ReleaseTaggerBot added a project to T393846: Remove ?stableid=: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).
Sat, May 17, 7:00 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs
Maintenance_bot removed a project from T393846: Remove ?stableid=: Patch-For-Review.
Sat, May 17, 6:30 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs
Novem_Linguae closed T393846: Remove ?stableid= as Resolved.
Sat, May 17, 6:11 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs
gerritbot added a comment to T393846: Remove ?stableid=.

Change #1143970 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] replace complex ?stableid= code with a redirect to ?oldid=

https://gerrit.wikimedia.org/r/1143970

Sat, May 17, 6:10 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs

Fri, May 16

Umherirrender added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .

CentralNotice is special about deployment, see T179536: Unexpected side-effect of CentralNotice wmf_deploy branch strategy

Fri, May 16, 8:07 PM · MediaWiki-extensions-CentralNotice, ci-test-error (WMF-deployed Build Failure)
PatchDemoBot added a comment to T365924: Place flaggedrevs_reviewform or mw-data-after-content in the body content area.

Test wiki on Patch demo by Doğu using patch(es) linked to this task was deleted:

Fri, May 16, 7:26 PM · Patch-For-Review, Vector 2022 (Desktop improvements) (Tracking), FlaggedRevs
Novem_Linguae updated subscribers of T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .

So this patch passed FlaggedRevs CI but broke CentralNotice CI? And only for branch wmf/1.45.0-wmf.1? Interesting.

Fri, May 16, 7:02 PM · MediaWiki-extensions-CentralNotice, ci-test-error (WMF-deployed Build Failure)
Reedy updated subscribers of T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Fri, May 16, 6:56 PM · MediaWiki-extensions-CentralNotice, ci-test-error (WMF-deployed Build Failure)
Reedy created T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Fri, May 16, 6:56 PM · MediaWiki-extensions-CentralNotice, ci-test-error (WMF-deployed Build Failure)
Maintenance_bot removed a project from T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel]: Patch-For-Review.
Fri, May 16, 4:30 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Change #1146634 abandoned by Novem Linguae:

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] Stabilization: convert deprecated Xml methods to Html

Reason:

In ticket, the group decided not to backport this.

https://gerrit.wikimedia.org/r/1146634

Fri, May 16, 3:44 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
jnuche closed T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel] as Resolved.

Volume of logs for this is small, I think we can close the task now that the fix is in master

Fri, May 16, 3:29 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
Novem_Linguae added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Do we want to backport this to keep log spam down?

Fri, May 16, 2:59 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error

Thu, May 15

ReleaseTaggerBot added a project to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel]: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).
Thu, May 15, 2:00 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Change #1146634 had a related patch set uploaded (by Jforrester; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146634

Thu, May 15, 1:59 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Change #1146624 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146624

Thu, May 15, 1:55 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
gerritbot added a project to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel]: Patch-For-Review.
Thu, May 15, 1:30 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Change #1146624 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146624

Thu, May 15, 1:30 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
Novem_Linguae claimed T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].
Thu, May 15, 12:54 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
Novem_Linguae added a comment to T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].

Steps to reproduce

  • make sure $wgFlaggedRevsProtection = false;
  • be an admin
  • go to the page protection screen
  • at the top, there is text that says "This page does not have a stable version; page stability settings can be configured.". Click "Configured"
  • this will take you to a page such as http://localhost:8080/w/index.php?title=Special:Stabilization&page=Test5, which has the deprecation warning.
Thu, May 15, 12:04 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
jnuche created T394403: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel].
Thu, May 15, 11:51 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), FlaggedRevs, Wikimedia-production-error
ReleaseTaggerBot added a project to T394381: Error: Call to a member function getId() on null: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).
Thu, May 15, 10:00 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Dreamy_Jazz closed T394381: Error: Call to a member function getId() on null as Resolved.
Thu, May 15, 9:48 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Stashbot added a comment to T394381: Error: Call to a member function getId() on null.

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:45:54Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]] (duration: 16m 00s)

Thu, May 15, 9:45 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Stashbot added a comment to T394381: Error: Call to a member function getId() on null.

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:36:36Z] <dreamyjazz@deploy1003> dreamyjazz, zabe: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Thu, May 15, 9:36 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Maintenance_bot removed a project from T394381: Error: Call to a member function getId() on null: Patch-For-Review.
Thu, May 15, 9:30 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Stashbot added a comment to T394381: Error: Call to a member function getId() on null.

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:29:53Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]]

Thu, May 15, 9:30 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394381: Error: Call to a member function getId() on null.

Change #1146528 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146528

Thu, May 15, 9:28 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
Dreamy_Jazz added a comment to T394381: Error: Call to a member function getId() on null.

Happy to backport this fix.

Thu, May 15, 9:25 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
jnuche added a comment to T394381: Error: Call to a member function getId() on null.

There is currently an issue that's preventing me from rolling back the train. Please note this will most likely also impact backports

Thu, May 15, 9:23 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394381: Error: Call to a member function getId() on null.

Change #1146528 had a related patch set uploaded (by Zabe; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146528

Thu, May 15, 9:14 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
gerritbot added a comment to T394381: Error: Call to a member function getId() on null.

Change #1146523 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146523

Thu, May 15, 9:12 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error
jnuche added a comment to T394381: Error: Call to a member function getId() on null.

There is currently an issue that's preventing me from rolling back the train. Please note this will most likely also impact backports

Thu, May 15, 9:00 AM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), FlaggedRevs, Wikimedia-production-error