Page MenuHomePhabricator
Create Task
Maniphest T394542

BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods
Closed, ResolvedPublic
Actions

Description

Seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1147043 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/98049/console

19:34:53 PHP Fatal error:  Class MediaWiki\Extensions\FlaggedRevs\Tests\Structure\BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (MediaWiki\Tests\Structure\BundleSizeTestBase::getBundleSizeConfigData) in /workspace/src/extensions/CentralNotice/tests/phpunit/structure/BundleSizeTest.php on line 13

Ping T393122: Make PHPUnit dataProvider on BundleSizeTestBase static

Details

SubjectRepoBranchLines +/-
Update incorrect PHP namespace in BundleSizeTestmediawiki/extensions/CentralNoticewmf/1.45.0-wmf.1+1 -1
Make BundleSizeTest cross-compatible with <=1.44 and >=1.45mediawiki/extensions/CentralNoticewmf/1.45.0-wmf.1+9 -1
Make BundleSizeTest cross-compatible with <=1.44 and >=1.45mediawiki/extensions/CentralNoticemaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Fri, May 16, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 16, 6:56 PM
Reedy added a subscriber: xSavitar.Fri, May 16, 6:56 PM
Novem_Linguae added subscribers: matmarex, Novem_Linguae.Fri, May 16, 7:02 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1143035

So this patch passed FlaggedRevs CI but broke CentralNotice CI? And only for branch wmf/1.45.0-wmf.1? Interesting.

Umherirrender subscribed.EditedFri, May 16, 8:07 PM

CentralNotice is special about deployment, see T179536: Unexpected side-effect of CentralNotice wmf_deploy branch strategy

The error message indicates an error in namespacing, fixed with 657c9cc4c50b3c1c8afdc573ca21fc714d6b8f07, relevant is the folder/file name, not the namespace/class name

Novem_Linguae edited projects, added MediaWiki-extensions-CentralNotice; removed FlaggedRevs.Fri, May 16, 8:10 PM
Novem_Linguae removed a subscriber: matmarex.

Got it. So the fix is probably to cherry pick 657c9cc4c50b3c1c8afdc573ca21fc714d6b8f07 into CentralNotice -> branch wmf/1.45.0-wmf.1.

gerritbot added a comment.Fri, May 16, 8:16 PM

Change #1147060 had a related patch set uploaded (by Reedy; author: Hashar):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Update incorrect PHP namespace in BundleSizeTest

https://gerrit.wikimedia.org/r/1147060

gerritbot added a project: Patch-For-Review.Fri, May 16, 8:16 PM
gerritbot added a comment.Mon, May 19, 6:31 PM

Change #1147839 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147839

gerritbot added a comment.Tue, May 20, 12:21 AM

Change #1147839 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147839

gerritbot added a comment.Tue, May 20, 1:25 AM

Change #1147910 had a related patch set uploaded (by Ejegg; author: Jgleeson):

[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147910

gerritbot added a comment.Tue, May 20, 1:33 AM

Change #1147910 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45

https://gerrit.wikimedia.org/r/1147910

gerritbot added a comment.Tue, May 20, 5:44 PM

Change #1147060 abandoned by Jforrester:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Update incorrect PHP namespace in BundleSizeTest

Reason:

Being done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1146631

https://gerrit.wikimedia.org/r/1147060

Maintenance_bot removed a project: Patch-For-Review.Tue, May 20, 6:30 PM
Umherirrender closed this task as Resolved.Sun, May 25, 2:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits