Centralised notice extension (Homepage)
To make a confidential Fundraising task, visible only to members of acl*WMF-FR click here: https://phabricator.wikimedia.org/maniphest/task/create/?template=89899
Details
Details
Yesterday
Yesterday
Wed, May 21
Wed, May 21
Jdlrobson-WMF updated the task description for T380079: This page is using the deprecated ResourceLoader module "mediawiki.Uri" on page load.
Tue, May 20
Tue, May 20
Stashbot added a comment to T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
Mentioned in SAL (#wikimedia-operations) [2025-05-20T21:06:31Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] (duration: 11m 28s)
Jdforrester-WMF closed T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher] as Resolved.
Should now be fixed.
Stashbot added a comment to T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:57:41Z] <jforrester@deploy1003> mszabo, jforrester: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes c
Stashbot added a comment to T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:55:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]]
gerritbot added a comment to T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
Change #1146631 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147060 abandoned by Jforrester:
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Update incorrect PHP namespace in BundleSizeTest
Reason:
Being done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1146631
jgleeson moved T394399: No longer able to preview centralnotice banners from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.
jgleeson updated subscribers of T394399: No longer able to preview centralnotice banners.
Maintenance_bot removed a project from T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1147910 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147910 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
gerritbot added a project to T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147910 had a related patch set uploaded (by Ejegg; author: Jgleeson):
[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1147910 had a related patch set uploaded (by Ejegg; author: Jgleeson):
[mediawiki/extensions/CentralNotice@master] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
Maintenance_bot removed a project from T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147839 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1147839 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
Mon, May 19
Mon, May 19
Jdlrobson-WMF added a comment to T394399: No longer able to preview centralnotice banners.
I chained your patches so they pass CI. You should be able to schedule them both for an available backport window using https://schedule-deployment.toolforge.org/
XenoRyet moved T394321: Add text to CentralNotice admin UI when user has admin but no 2FA from Triage to Later on the Fundraising-Backlog board.
XenoRyet closed T374625: new wording for CN &banner= CSP error message, a subtask of T199055: &banner causes CSP warning, as Resolved.
Damilare moved T374625: new wording for CN &banner= CSP error message from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.
greg moved T394399: No longer able to preview centralnotice banners from Backlog to Pending Deployment on the Fundraising Tech - Chaos Crew board.
XenoRyet moved T394399: No longer able to preview centralnotice banners from Triage to DRI Backlog on the Fundraising-Backlog board.
jgleeson updated subscribers of T394399: No longer able to preview centralnotice banners.
@Jdlrobson I just pushed up a patch to fix the CI failures relating to the namespace fix here.
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147839 had a related patch set uploaded (by Jgleeson; author: Jgleeson):
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
gerritbot added a project to T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1147839 had a related patch set uploaded (by Jgleeson; author: Jgleeson):
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Make BundleSizeTest cross-compatible with <=1.44 and >=1.45
Fri, May 16
Fri, May 16
gerritbot added a comment to T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods .
Change #1147060 had a related patch set uploaded (by Reedy; author: Hashar):
[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Update incorrect PHP namespace in BundleSizeTest
Novem_Linguae edited projects for T394542: BundleSizeTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods , added: MediaWiki-extensions-CentralNotice; removed FlaggedRevs.
Got it. So the fix is probably to cherry pick 657c9cc4c50b3c1c8afdc573ca21fc714d6b8f07 into CentralNotice -> branch wmf/1.45.0-wmf.1.
KMorrow-WMF added a comment to T394399: No longer able to preview centralnotice banners.
Jdlrobson-WMF added a comment to T394399: No longer able to preview centralnotice banners.
Does this need backporting or is it okay to go out on the train next week? If backporting when (today? Monday?) and who ?
Thu, May 15
Thu, May 15
Maintenance_bot removed a project from T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1146648 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Fixes iteration of existing URLSearchParams
Jdlrobson-WMF added a comment to T394399: No longer able to preview centralnotice banners.
There is an API request to https://meta.wikimedia.org/w/index.php?title=Special:BannerLoader&banner=undefined&uselang=en&debug=false
Debugging I was able to confirm getBannerURL is called with a data object with no banner key - which led to above patch.
gerritbot added a project to T394399: No longer able to preview centralnotice banners: Patch-For-Review.
gerritbot added a comment to T394399: No longer able to preview centralnotice banners.
Change #1146648 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/CentralNotice@master] Fixes iteration of existing URLSearchParams
jnuche added a comment to T394404: PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher].
@jnuche: This should kill off the logspam and otherwise do nothing except an i18n update (sorry :-().