Page MenuHomePhabricator
Create Task
Maniphest T394403

PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::radioLabel]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(497)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.1/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(390)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(497)MediaWiki\Xml\Xml::radio(string, string, bool, array)
#7/srv/mediawiki/php-1.45.0-wmf.1/extensions/FlaggedRevs/includes/frontend/specialpages/actions/Stabilization.php(182)MediaWiki\Xml\Xml::radioLabel(string, string, string, string, bool, array)
#8/srv/mediawiki/php-1.45.0-wmf.1/extensions/FlaggedRevs/includes/frontend/specialpages/actions/Stabilization.php(106)Stabilization->showForm()
#9/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPage.php(734)Stabilization->execute(null)
#10/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1738)MediaWiki\SpecialPage\SpecialPage->run(null)
#11/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#12/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#13/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#14/srv/mediawiki/php-1.45.0-wmf.1/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/index.php(3)require(string)
#16{main}
Notes

Another deprecation warning that started with 1.45.0-wmf.1. Very low volume, 96 hits in the last two days.

The error refers to Xml::radio, but the calling code (Xml::radioLabel) itself seems to have been deprecated since 1.42: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/refs/heads/wmf/1.45.0-wmf.1/includes/xml/Xml.php#492.
There are two calls of it here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/+blame/refs/heads/wmf/1.45.0-wmf.1/includes/frontend/specialpages/actions/Stabilization.php#181

(@Jdforrester-WMF I saw you paying attention to other deprecation messages and though you might be interested, sorry for spamming if that's not the case)

Details

Request URL
https://en.wikinews.org/w/index.php?page=*&title=*
SubjectRepoBranchLines +/-
Stabilization: convert deprecated Xml methods to Htmlmediawiki/extensions/FlaggedRevswmf/1.45.0-wmf.1+26 -12
Stabilization: convert deprecated Xml methods to Htmlmediawiki/extensions/FlaggedRevsmaster+26 -12
Customize query in gerrit

Related Objects

Event Timeline

jnuche created this task.Thu, May 15, 11:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, May 15, 11:51 AM
Ladsgroup subscribed.Thu, May 15, 11:57 AM
Novem_Linguae added a comment.Thu, May 15, 12:04 PM

Steps to reproduce

  • make sure $wgFlaggedRevsProtection = false;
  • be an admin
  • go to the page protection screen
  • at the top, there is text that says "This page does not have a stable version; page stability settings can be configured.". Click "Configured"
  • this will take you to a page such as http://localhost:8080/w/index.php?title=Special:Stabilization&page=Test5, which has the deprecation warning.
Novem_Linguae claimed this task.Thu, May 15, 12:54 PM
gerritbot added a comment.Thu, May 15, 1:30 PM

Change #1146624 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146624

gerritbot added a project: Patch-For-Review.Thu, May 15, 1:30 PM
gerritbot added a comment.Thu, May 15, 1:55 PM

Change #1146624 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146624

gerritbot added a comment.Thu, May 15, 1:59 PM

Change #1146634 had a related patch set uploaded (by Jforrester; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] Stabilization: convert deprecated Xml methods to Html

https://gerrit.wikimedia.org/r/1146634

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).Thu, May 15, 2:00 PM
Novem_Linguae added a comment.Fri, May 16, 2:59 PM

Do we want to backport this to keep log spam down?

Otherwise I think this ticket is solved by the patch and can be closed.

jnuche closed this task as Resolved.Fri, May 16, 3:29 PM

Volume of logs for this is small, I think we can close the task now that the fix is in master

gerritbot added a comment.Fri, May 16, 3:44 PM

Change #1146634 abandoned by Novem Linguae:

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] Stabilization: convert deprecated Xml methods to Html

Reason:

In ticket, the group decided not to backport this.

https://gerrit.wikimedia.org/r/1146634

Maintenance_bot removed a project: Patch-For-Review.Fri, May 16, 4:30 PM
Jdforrester-WMF mentioned this in T394025: PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep].Tue, May 27, 5:25 PM
Jdforrester-WMF mentioned this in T395357: PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep].
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits