Error: Call to a member function getId() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jnuche
	Thu, May 15, 8:37 AM

Description

Error

service.version: 1.45.0-wmf.1
trace.id: 965eaee2-2b7a-4cdb-9ae1-f543fcaa1042
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getId() on null

Frame	Location	Call
from	/srv/mediawiki/php-1.45.0-wmf.1/extensions/FlaggedRevs/includes/frontend/FlaggablePageView.php(832)
#0	/srv/mediawiki/php-1.45.0-wmf.1/extensions/FlaggedRevs/includes/frontend/FlaggablePageView.php(406)	FlaggablePageView->showUnreviewedVersion(string)
#1	/srv/mediawiki/php-1.45.0-wmf.1/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(508)	FlaggablePageView->setPageContent(null, null)
#2	/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(2010)	MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->execute()
#3	/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(948)	MediaWiki\Api\ApiMain->executeAction()
#4	/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(919)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#5	/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#6	/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)	MediaWiki\Api\ApiEntryPoint->execute()
#7	/srv/mediawiki/php-1.45.0-wmf.1/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#8	/srv/mediawiki/w/api.php(3)	require(string)
#9	{main}

Notes

Continuous stream of errors after rolling out 1.45.0-wmf.1 to all wikis. Multiple wikis affected, so far seen: ruwiki, ukwiki, eowiki, plwiki and dewiki

Cause seems to be https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1114959/6

Affects the FlaggedRevs extension, which makes me worried about the impact. Marking as UBN!

Details

Request URL: https://eo.wikipedia.org/w/api.php

Subject	Repo	Branch	Lines +/-
FlaggablePageView: add comments	mediawiki/extensions/FlaggedRevs	master	+5 -1
FlaggablePageView: don't call getId() on null	mediawiki/extensions/FlaggedRevs	wmf/1.45.0-wmf.1	+4 -1
FlaggablePageView: don't call getId() on null	mediawiki/extensions/FlaggedRevs	master	+4 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jnuche	T392171 1.45.0-wmf.1 deployment blockers
		Resolved	PRODUCTION ERROR	Novem_Linguae	T394381 Error: Call to a member function getId() on null

Event Timeline

jnuche triaged this task as Unbreak Now! priority.Thu, May 15, 8:37 AM

jnuche created this task.

Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptThu, May 15, 8:37 AM

jnuche added a parent task: T392171: 1.45.0-wmf.1 deployment blockers.Thu, May 15, 8:37 AM

Zabe subscribed.Thu, May 15, 8:46 AM

Novem_Linguae claimed this task.Thu, May 15, 8:47 AM

Change #1146523 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146523

gerritbot added a project: Patch-For-Review.Thu, May 15, 8:50 AM

There is currently an issue that's preventing me from rolling back the train. Please note this will most likely also impact backports

Change #1146523 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146523

Change #1146528 had a related patch set uploaded (by Zabe; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146528

There is currently an issue that's preventing me from rolling back the train. Please note this will most likely also impact backports

This now seems fixed, we can go ahead with a backport. Thanks for tackling this so quickly @Novem_Linguae!

Happy to backport this fix if Zabe isn't doing that.

Change #1146528 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.45.0-wmf.1] FlaggablePageView: don't call getId() on null

https://gerrit.wikimedia.org/r/1146528

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:29:53Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]]

Maintenance_bot removed a project: Patch-For-Review.Thu, May 15, 9:30 AM

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:36:36Z] <dreamyjazz@deploy1003> dreamyjazz, zabe: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-05-15T09:45:54Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1146528|FlaggablePageView: don't call getId() on null (T394381)]] (duration: 16m 00s)

Dreamy_Jazz closed this task as Resolved.Thu, May 15, 9:48 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).Thu, May 15, 10:00 AM

Change #1147804 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add comments

https://gerrit.wikimedia.org/r/1147804

gerritbot added a project: Patch-For-Review.Mon, May 19, 3:49 PM

Change #1147804 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add comments

https://gerrit.wikimedia.org/r/1147804

Maintenance_bot removed a project: Patch-For-Review.Tue, May 20, 1:30 PM

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).Tue, May 20, 2:00 PM