Page MenuHomePhabricator

MediaWiki-EmailComponent
ActivePublic

Members (5)

Watchers (4)

Details

Description

Issues relating to the email-related features, such as "enotif" watchlist notifications, Special:ConfirmEmail, Special:EmailUser, etc.

This project is part of the core MediaWiki software itself.

For issues pertaining to Wikimedia's email/SMTP infrastructure see Mail instead.

This tag is distinct from MediaWiki-Notifications, which covers issues in the new notifications system being developed in 2025.

Recent Activity

Today

E_L_Y updated subscribers of T387111: Comma with Hebrew letters in username conflict with confirmation mail.

Hi, it seems that the issue exists also for double quotation marks, " (again, combined with Hebrew letters).
Thanks to the user who reported this case, and thanks @Kipod for verifying!

Wed, May 28, 12:47 PM · MediaWiki-Email, MediaWiki-User-login-and-signup

Thu, May 22

pmiazga added a comment to T387856: Deprecate EnotifImpersonal.

Deprecated and removed. Thank you Jdforrester and Matmarex \o/

Thu, May 22, 3:44 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), MW-1.45-release, MediaWiki-Email, MediaWiki-Notifications

Wed, May 21

Maintenance_bot removed a project from T387856: Deprecate EnotifImpersonal: Patch-For-Review.
Wed, May 21, 10:30 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), MW-1.45-release, MediaWiki-Email, MediaWiki-Notifications
ReleaseTaggerBot added a project to T387856: Deprecate EnotifImpersonal: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).
Wed, May 21, 10:00 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), MW-1.45-release, MediaWiki-Email, MediaWiki-Notifications
gerritbot added a comment to T387856: Deprecate EnotifImpersonal.

Change #1126107 merged by jenkins-bot:

[mediawiki/core@master] Drop wgEnotifImpersonal and wgEnotifMaxRecips support, deprecated in 1.44

https://gerrit.wikimedia.org/r/1126107

Wed, May 21, 9:45 PM · MW-1.45-notes (1.45.0-wmf.3; 2025-05-27), MW-1.44-notes (1.44.0-wmf.20; 2025-03-11), MW-1.45-release, MediaWiki-Email, MediaWiki-Notifications

Sun, May 18

Pppery edited projects for T209462: “Page moved” email notification leads to the old location, added: MediaWiki-Page-rename; removed Growth-Team-Filtering, Growth-Team.
Sun, May 18, 2:49 AM · MediaWiki-Page-rename, Google-Code-in-2019, MediaWiki-Email

Wed, May 14

DMburugu moved T358087: Create user preference to receive change notification emails for bot edits from Inbox to Triaged on the Moderator-Tools-Team board.
Wed, May 14, 12:43 PM · Moderator-Tools-Team, MediaWiki-Email, MediaWiki-Watchlist, MediaWiki-Core-Preferences, Mail

Tue, May 13

matmarex closed T388004: Deprecate `AbortTalkPageEmailNotification` hook as Resolved.
Tue, May 13, 2:05 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1137465 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] Deprecate the AbortTalkPageEmailNotificationHook

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1143833

https://gerrit.wikimedia.org/r/1137465

Tue, May 13, 2:05 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
ReleaseTaggerBot added projects to T388004: Deprecate `AbortTalkPageEmailNotification` hook: MW-1.44-notes, MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).
Tue, May 13, 2:00 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1144698 merged by jenkins-bot:

[mediawiki/core@REL1_44] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1144698

Tue, May 13, 1:40 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1144698 had a related patch set uploaded (by Bartosz Dziewoński; author: Pmiazga):

[mediawiki/core@REL1_44] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1144698

Tue, May 13, 1:25 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1143833 merged by jenkins-bot:

[mediawiki/core@master] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1143833

Tue, May 13, 1:21 AM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)

Mon, May 12

pmiazga moved T388004: Deprecate `AbortTalkPageEmailNotification` hook from Epics to In progress on the MediaWiki-Notifications board.
Mon, May 12, 4:52 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
pmiazga moved T388004: Deprecate `AbortTalkPageEmailNotification` hook from In progress to Epics on the MediaWiki-Notifications board.
Mon, May 12, 4:51 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)

Fri, May 9

gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1143833 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1143833

Fri, May 9, 1:47 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
pmiazga claimed T388004: Deprecate `AbortTalkPageEmailNotification` hook.
Fri, May 9, 1:35 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
pmiazga moved T388004: Deprecate `AbortTalkPageEmailNotification` hook from Planned to In progress on the MediaWiki-Notifications board.
Fri, May 9, 1:35 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
pmiazga moved T388004: Deprecate `AbortTalkPageEmailNotification` hook from Backlog to Planned on the MediaWiki-Notifications board.
Fri, May 9, 1:16 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
A_smart_kitten added projects to T358087: Create user preference to receive change notification emails for bot edits: MediaWiki-Core-Preferences, MediaWiki-Watchlist, MediaWiki-Email.
Fri, May 9, 7:47 AM · Moderator-Tools-Team, MediaWiki-Email, MediaWiki-Watchlist, MediaWiki-Core-Preferences, Mail

Wed, May 7

gerritbot added a comment to T388001: Migrate ENotif Watchlist Notifications.

Change #1137041 abandoned by Pmiazga:

[mediawiki/core@master] WIP: ENotif: IDEA: Simplify system by dropping source

Reason:

Abandoning the change. The source is important to determine the notification type when handling Admin notifications.

https://gerrit.wikimedia.org/r/1137041

Wed, May 7, 1:25 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications

Thu, May 1

matmarex closed T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222 as Resolved.
Thu, May 1, 11:25 AM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error

Wed, Apr 30

hashar added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

The patch has been deployed but the train is blocked on an issue we have with Gerrit ( T393034 ).

Wed, Apr 30, 5:14 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
hashar added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

There was a Gerrit maintenance that started immediately after the patch got merged. It is now being deployed by Timo as part of another deployment!

Wed, Apr 30, 4:38 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
ReleaseTaggerBot added a project to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).
Wed, Apr 30, 4:00 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
Maintenance_bot removed a project from T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222: Patch-For-Review.
Wed, Apr 30, 3:30 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
gerritbot added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

Change #1140184 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.25] EnotifNotifyJob: Forward-compat for wmf.27 jobs

https://gerrit.wikimedia.org/r/1140184

Wed, Apr 30, 3:11 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
hashar added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

Matmarex has verified the patch works for him. I will look at deploying https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1140184 .

Wed, Apr 30, 2:53 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

Looks good to me.

Wed, Apr 30, 2:37 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

Test plan (on a local test wiki):

  • Make sure jobs don't run automatically
  • Switch to wmf.27
  • Make some edits, causing some jobs to be generated
  • Switch to wmf.25
  • Run jobs – This should cause errors like in the task
  • Apply the patch
  • Run jobs again – This time they should succeed, and they should send correct email notifications
Wed, Apr 30, 2:02 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

That patch is only for wmf.25 and should unblock the wmf.27 deployment.

Wed, Apr 30, 1:58 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
gerritbot added a project to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222: Patch-For-Review.
Wed, Apr 30, 1:57 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
gerritbot added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

Change #1140184 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.44.0-wmf.25] EnotifNotifyJob: Forward-compat for wmf.27 jobs

https://gerrit.wikimedia.org/r/1140184

Wed, Apr 30, 1:57 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
matmarex added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

So maybe just a deploy artifact during the time when the servers had mixed code, so wmf.27 created jobs that were processed by wmf.25?

Wed, Apr 30, 1:39 PM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
Tgr added a comment to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.

rMW4dfbf67f4d63: Pass RecentChange back to EmailNotif changed EnotifNotifyJob (which eventually passes some of its parameters to RecentChangeMailComposer) to not have a timestamp. This is not a cross-wiki job; it would be understandable if existing jobs started to fail (because the job parameters were stored with the wmf.25 code but processed with the wmf.27 code) but this error seems to be the other way around - it's the old code that passed an explicit timestamp and the new one that doesn't (and the errors are also thrown on the old branch). So maybe just a deploy artifact during the time when the servers had mixed code, so wmf.27 created jobs that were processed by wmf.25? The error spike is not that narrow, but then wmf.27 jobs would keep erroring after the rollback so that's to be expected.

Wed, Apr 30, 10:38 AM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error
A_smart_kitten added a project to T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222: MediaWiki-Email.
Wed, Apr 30, 8:43 AM · MW-1.44-notes (1.44.0-wmf.25; 2025-04-15), MediaWiki-Email, MediaWiki-Platform-Team, Wikimedia-production-error

Apr 23 2025

matmarex closed T388001: Migrate ENotif Watchlist Notifications as Resolved.
Apr 23 2025, 3:31 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications

Apr 18 2025

gerritbot added a project to T388004: Deprecate `AbortTalkPageEmailNotification` hook: Patch-For-Review.
Apr 18 2025, 5:16 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
gerritbot added a comment to T388004: Deprecate `AbortTalkPageEmailNotification` hook.

Change #1137465 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] Deprecate the AbortTalkPageEmailNotificationHook

https://gerrit.wikimedia.org/r/1137465

Apr 18 2025, 5:16 PM · MW-1.45-notes (1.45.0-wmf.2; 2025-05-20), MW-1.44-notes, MediaWiki-Email, MediaWiki-Notifications, MediaWiki-Platform-Team (Roadmap)
ReleaseTaggerBot added a project to T388001: Migrate ENotif Watchlist Notifications: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).
Apr 18 2025, 12:00 AM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications

Apr 17 2025

gerritbot added a comment to T388001: Migrate ENotif Watchlist Notifications.

Change #1137036 merged by jenkins-bot:

[mediawiki/core@master] ENotif: Migrate the Watchlist notification

https://gerrit.wikimedia.org/r/1137036

Apr 17 2025, 11:06 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications
matmarex moved T388001: Migrate ENotif Watchlist Notifications from Roadmap to In progress on the MediaWiki-Platform-Team board.
Apr 17 2025, 11:06 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications

Apr 16 2025

gerritbot added a comment to T388001: Migrate ENotif Watchlist Notifications.

Change #1137041 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] WIP: ENotif: IDEA: Simplify system by dropping source

https://gerrit.wikimedia.org/r/1137041

Apr 16 2025, 4:59 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications
gerritbot added a project to T388001: Migrate ENotif Watchlist Notifications: Patch-For-Review.
Apr 16 2025, 4:23 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications
gerritbot added a comment to T388001: Migrate ENotif Watchlist Notifications.

Change #1137036 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] ENotif: Migrate the Watchlist notification

https://gerrit.wikimedia.org/r/1137036

Apr 16 2025, 4:22 PM · MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), MediaWiki-Platform-Team, MediaWiki-Email, MediaWiki-Notifications

Apr 15 2025

dom_walden updated the task description for T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser.
Apr 15 2025, 11:53 AM · Trust and Safety Product Team, MediaWiki-Blocks, Stewards-and-global-tools, MediaWiki-Email, MediaWiki-extensions-CentralAuth
dom_walden added a comment to T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser.

I have no memory of raising this bug...

Apr 15 2025, 11:49 AM · Trust and Safety Product Team, MediaWiki-Blocks, Stewards-and-global-tools, MediaWiki-Email, MediaWiki-extensions-CentralAuth

Apr 14 2025

Xaosflux added a comment to T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser.

Without having the user story updated, this looks like it can be closed as not a bug.

Apr 14 2025, 7:54 PM · Trust and Safety Product Team, MediaWiki-Blocks, Stewards-and-global-tools, MediaWiki-Email, MediaWiki-extensions-CentralAuth
Xaosflux added a comment to T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser.

Note, for WMF wikis - in practice we don't hide users unless we are also locking users, which will alleviate the user story

Apr 14 2025, 7:52 PM · Trust and Safety Product Team, MediaWiki-Blocks, Stewards-and-global-tools, MediaWiki-Email, MediaWiki-extensions-CentralAuth
Restricted Application added a project to T231867: [BUG] CentralAuth hide/suppress does not block Special:EmailUser: Trust and Safety Product Team.
Apr 14 2025, 7:18 PM · Trust and Safety Product Team, MediaWiki-Blocks, Stewards-and-global-tools, MediaWiki-Email, MediaWiki-extensions-CentralAuth