Page MenuHomePhabricator

Add SUL3 flag to authentication-related event schemas
Closed, ResolvedPublic

Description

Add a "SUL3 enabled" flag to all events which are related to authentication and so the SUL3 rollout might affect them:

To group0 (Phase 1: T384007: SUL3 Phase 1: All new account creation on group 0 and group 1 wikis)

Details

TitleReferenceAuthorSource BranchDest Branch
Add SUL3 flag to the `editattempstep` secondary event schemarepos/data-engineering/schemas-event-secondary!47derickT377253-update-editattempstep-schemamaster
Add SUL3 flag to 'block' & 'account_conversion' event schemasrepos/data-engineering/schemas-event-secondary!43derickadd-sul3-to-schema-block-and-account-conversionmaster
1.3.0 version of /analytics/legacy/serversideaccountcreationrepos/data-engineering/schemas-event-secondary!42derickadd-sul3-to-schemamaster
Customize query in GitLab

Event Timeline

We should probably track how many people visit the login / signup pages with the sul3 flag on/off. I'll make a separate task for that.

Change #1114374 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Campaigns@master] Track usage of SUL3 via event schemas

https://gerrit.wikimedia.org/r/1114374

We should probably track how many people visit the login / signup pages with the sul3 flag on/off. I'll make a separate task for that.

Added to T377261: Track the number of interrupted SUL3 logins / signups which is more or less the same thing.

Change #1114374 merged by jenkins-bot:

[mediawiki/extensions/Campaigns@master] Track usage of SUL3 via event schemas

https://gerrit.wikimedia.org/r/1114374

Change #1114782 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/WikimediaEvents@master] Track usage of SUL3 via event schemas

https://gerrit.wikimedia.org/r/1114782

do we have an event schema for login?

@Tgr, I just did a quick grep (grep -rl "login" .) in the schemas-event-secondary repo and the files listed don't seem to be largely related. The closest I'm seeing is analytics schemas related to mobile apps login action. Not sure if we need to do anything there. The rest are not related, so maybe we don't have a dedicated schema for login actions I think.

./jsonschema/analytics/legacy/universallanguageselector/1.5.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.1.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.3.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.6.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/current.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.6.1.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.4.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.0.0.yaml
./jsonschema/analytics/legacy/universallanguageselector/1.2.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.5.1.yaml
./jsonschema/analytics/legacy/homepagevisit/1.5.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.1.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.1.1.yaml
./jsonschema/analytics/legacy/homepagevisit/1.3.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.6.0.yaml
./jsonschema/analytics/legacy/homepagevisit/current.yaml
./jsonschema/analytics/legacy/homepagevisit/1.4.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.0.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.2.1.yaml
./jsonschema/analytics/legacy/homepagevisit/1.2.0.yaml
./jsonschema/analytics/legacy/homepagevisit/1.5.2.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/4.0.0.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/3.0.0.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/2.0.0.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/4.1.0.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/current.yaml
./jsonschema/analytics/mobile_apps/ios_watchlists/1.0.0.yaml
./jsonschema/analytics/mobile_apps/ios_login_action/1.0.2.yaml
./jsonschema/analytics/mobile_apps/ios_login_action/1.1.0.yaml
./jsonschema/analytics/mobile_apps/ios_login_action/current.yaml
./jsonschema/analytics/mobile_apps/ios_login_action/1.0.0.yaml
./jsonschema/analytics/mobile_apps/ios_login_action/1.0.1.yaml
./jsonschema/analytics/mediawiki/mentor_dashboard/visit/1.1.0.yaml
./jsonschema/analytics/mediawiki/mentor_dashboard/visit/current.yaml
./jsonschema/analytics/mediawiki/mentor_dashboard/visit/1.0.0.yaml
./jsonschema/analytics/mediawiki/mentor_dashboard/visit/1.0.1.yaml
./jsonschema/analytics/mediawiki/accountcreation/account_conversion/1.1.0.yaml
./jsonschema/analytics/mediawiki/accountcreation/account_conversion/current.yaml
./jsonschema/analytics/mediawiki/accountcreation/account_conversion/1.0.0.yaml
DAlangi_WMF changed the task status from Open to In Progress.Jan 29 2025, 2:26 PM
DAlangi_WMF updated the task description. (Show Details)

The mobile apps use the API so they will never use SUL3 (and in general the whole project is not really relevant to them, since they are not bound by browser limitations and can just reuse cookies between sites).

The mobile apps use the API so they will never use SUL3 (and in general the whole project is not really relevant to them, since they are not bound by browser limitations and can just reuse cookies between sites).

Ack! I guess that resolves the question then. I'll go ahead and update the task. Thanks!

Change #1114782 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Track usage of SUL3 via event schemas

https://gerrit.wikimedia.org/r/1114782

Change #1117156 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/WikiEditor@master] Track usage of SUL3 via event `editattempstep` schemas

https://gerrit.wikimedia.org/r/1117156

Yeah, VisualEditor logs to editattemptstep from the client side.

We can figure that out later; editattemptstep is only needed (if at all) to track temp user creation, and we won't enable for temp users for a couple more weeks. The part that's a Phase 1 blocker is now merged and on this week's train. Thanks!

So apparently accountcreation/account_conversion can be sent into two different event streams, mediawiki.accountcreation.account_conversion and mediawiki.accountcreation.login, depending whether it is a signup or a login. A bit confusing, but it means the existing patch covered both login and signup.

So apparently accountcreation/account_conversion can be sent into two different event streams, mediawiki.accountcreation.account_conversion and mediawiki.accountcreation.login, depending whether it is a signup or a login. A bit confusing, but it means the existing patch covered both login and signup.

Sounds nice! A simple CodeSearch search: https://codesearch.wmcloud.org/search/?q=%28STREAM_LOGIN%7CSTREAM_REGISTER%29&files=&excludeFiles=&repos= shows the login vs create account/account conversion streams.

DAlangi_WMF changed the task status from In Progress to Open.Feb 10 2025, 1:08 PM
DAlangi_WMF moved this task from In progress to Blocked/waiting on the MediaWiki-Platform-Team board.

Waiting for the next stage of SUL3 rollout. The things needed for rolling out to group0 have been completed and already on the train deployment (this week).

We haven't had the time for editattemptstep, but I don't think it was very important in the first place.

Change #1117156 abandoned by D3r1ck01:

[mediawiki/extensions/WikiEditor@master] Track usage of SUL3 via event `editattempstep` schemas

Reason:

No longer needed.

https://gerrit.wikimedia.org/r/1117156