[Routing] Fix case sensitivity for static host matching in compiled routes #62459
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Routing/Matcher/Dumper/CompiledUrlMatcherDumper.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
routing-compiled-static-host-case
branch
from
e1f1dd8 to
9c33b1f
Compare
Member
|
Thank you @yoeunes. |
This was referenced Nov 21, 2025
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompiledUrlMatcheruses string comparison for static hosts, but checks lowercased request host against the original route host. This fails if the route host has uppercase letters (e.g.,'api.example.com' !== 'API.example.com'), throwingResourceNotFoundException.UrlMatcheravoids this via case-insensitive regex.This PR lowercases static hosts in
CompiledUrlMatcherDumperfor consistency.