[Console] Fix signal handlers not being cleared after command termination #62335
+310
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch " Cheers! Carsonbot |
yoeunes
force-pushed
the
console-signal-handler-leak
branch
7 times, most recently
from
3924c80 to
b88619d
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Please rebase/retarget for 6.4 since that's a bugfix that applies there.
src/Symfony/Component/Console/SignalRegistry/SignalRegistry.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Console/SignalRegistry/SignalRegistry.php
Outdated
Show resolved
Hide resolved
yoeunes
force-pushed
the
console-signal-handler-leak
branch
from
b88619d to
2fd421b
Compare
yoeunes
force-pushed
the
console-signal-handler-leak
branch
from
2fd421b to
559e878
Compare
nicolas-grekas
approved these changes
Nov 12, 2025
nicolas-grekas
force-pushed
the
console-signal-handler-leak
branch
from
559e878 to
6731fff
Compare
Member
|
Thank you @yoeunes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR fixes a bug where signal handlers would leak in long-running processes (e.g., Scheduler). When the same command was run multiple times, handlers would accumulate, causing a single OS signal to be handled repeatedly.