bug #62544 [DependencyInjection] Ensure deprecation detection does not trigger a PHP error (bnf)

nicolas-grekas · nicolas-grekas · commit af4cee66a755 · 2025-12-04T18:46:24.000+01:00
This PR was merged into the 7.4 branch. Discussion ---------- [DependencyInjection] Ensure deprecation detection does not trigger a PHP error `Exception Interface "TYPO3\CMS\Reports\StatusProviderInterface" not found` See https://forge.typo3.org/issues/108349 | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62589 | License | MIT The `class_exists` check and the condition `$definition instanceof ChildDefinition` have been swapped with #61215 in order to produce an error if a service is not available. This error was later relaxed in #61270, but the executing order of the condition kept to be `class_exists` first, then `instanceof`. That means, if `class_exists` fails with a PHP error (like PHP Fatal Error: Interface "My\Vendor\MyInterface" not found`) affected uses will not see the deprecation, but a fatal error instead. Commits ------- 662d28f [DependencyInjection] Ensure deprecation detection does not trigger a PHP error
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ResolveClassPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ResolveClassPass.php
@@ -29,7 +29,7 @@ public function process(ContainerBuilder $container): void
             ) {
                 continue;
             }
-            if (class_exists($id) || interface_exists($id, false)) {
+            if ($container->getReflectionClass($id, false)) {
                 $definition->setClass($id);
                 continue;
             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveClassPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveClassPassTest.php
@@ -107,4 +107,28 @@ public function testInvalidClassNameDefinition()
 
         (new ResolveClassPass())->process($container);
     }
+
+    #[IgnoreDeprecations]
+    #[Group('legacy')]
+    public function testInvalidClassWhoseImplementedInterfaceIsMissingDefinition()
+    {
+        $this->expectUserDeprecationMessage('Since symfony/dependency-injection 7.4: Service id "Acme\ClassImplementsUnavailableInterface" looks like a FQCN but no corresponding class or interface exists. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class or interface.');
+
+        $autoloader = function (string $class) {
+            if ('Acme\ClassImplementsUnavailableInterface' === $class) {
+                new class implements UnavailableInterface {};
+            }
+        };
+
+        spl_autoload_register($autoloader);
+
+        try {
+            $container = new ContainerBuilder();
+            $container->register('Acme\ClassImplementsUnavailableInterface');
+
+            (new ResolveClassPass())->process($container);
+        } finally {
+            spl_autoload_unregister($autoloader);
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function process(ContainerBuilder $container): void`
`29`	`29`	`) {`
`30`	`30`	`continue;`
`31`	`31`	`}`
`32`		`- if (class_exists($id) \|\| interface_exists($id, false)) {`
	`32`	`+ if ($container->getReflectionClass($id, false)) {`
`33`	`33`	`$definition->setClass($id);`
`34`	`34`	`continue;`
`35`	`35`	`}`