bug #62586 [DependencyInjection][FrameworkBundle] fix BC break when dumping container for build/lint commands (aschempp)

nicolas-grekas · nicolas-grekas · commit f0c6c7969b0c · 2025-12-04T18:16:53.000+01:00
This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [DependencyInjection][FrameworkBundle] fix BC break when dumping container for build/lint commands | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT #60597 introduced a BC break in that it assumes the `ContainerBuilder` constructor accepts the parameter bag as its first argument. However, in our application, we have a custom version of the `ContainerBuilder`. Since the container is already built at this state, I understand that calling `__construct()` again is just a hack to re-set the parameter bag. A direct setter function for this case should fix the issue. PS: `Kernel::buildContainer` must always return an instance of `ContainerBuilder`, so the setter method must always be there (our class inherits from it as well). Links: - Original issue: contao/contao#9058 - Custom `ContainerBuilder` https://github.com/contao/manager-plugin/blob/main/src/Config/ContainerBuilder.php Commits ------- 843fbca [DependencyInjection][FrameworkBundle] fix BC break when dumping container for build/lint commands
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php b/src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php
@@ -64,7 +64,10 @@ protected function getContainerBuilder(KernelInterface $kernel): ContainerBuilde
                 $dumpedContainer = unserialize(file_get_contents(substr_replace($file, '.ser', -4)));
                 $container->setDefinitions($dumpedContainer->getDefinitions());
                 $container->setAliases($dumpedContainer->getAliases());
-                $container->__construct($dumpedContainer->getParameterBag());
+
+                $parameterBag = $container->getParameterBag();
+                $parameterBag->clear();
+                $parameterBag->add($dumpedContainer->getParameterBag()->all());
             } else {
                 (new XmlFileLoader($container, new FileLocator()))->load($file);
                 $locatorPass = new ServiceLocatorTagPass();
