Skip to content

fix: Add ARIA attributes and roles to print disability dynamic section #11560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mystic-06 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Add ARIA attributes and roles to print disability dynamic section #11560

mystic-06 wants to merge 2 commits into from
+25 −6

Conversation

@mystic-06
Copy link

@mystic-06 mystic-06 commented Dec 6, 2025

Closes #10801

Fix

Technical

  • Added aria-expanded and aria-controls to the print disability checkbox
  • Added role="region", aria-hidden, and aria-labelledby to the dropdown container
  • Added aria-describedby, aria-required, and aria-invalid to the program selector
  • Added role="alert" + aria-live="polite" for error messaging
  • Updated JS to toggle ARIA states dynamically (expanded/hidden/required/invalid) based on checkbox state
  • Added safety null checks to avoid JS errors when elements are not present

Testing

  • Tested with Orca on Linux (CachyOS/GNOME)
  • Verified ARIA state changes through browser DevTools
  • Confirmed error messages are announced correctly
  • Checked keyboard navigation (Tab/Space/Enter/Arrow keys)
  • All existing unit tests pass

@github-actions github-actions bot added the Priority: 2 Important, as time permits. [managed] label Dec 6, 2025
@mystic-06 mystic-06 force-pushed the fix/10801-registration-form-accessibility branch from 9ab795a to 0140821 Compare December 9, 2025 09:18
@mystic-06
Copy link
Author

mystic-06 commented Dec 9, 2025 •
edited
Loading

Hi @jimchamp ! I know maintainers are busy, but I wanted to check in on this PR.
If there’s any feedback or anything I might have missed, I'd be glad to address it.
Thank you!

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jimchamp jimchamp

Labels

Needs: Response Issues which require feedback from lead Priority: 2 Important, as time permits. [managed]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ARIA roles and attributes to account registration page

2 participants

@mystic-06 @jimchamp