Skip to content

NeTEx: résultats lus du format binaire #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptitfred merged 12 commits into from
Dec 16, 2025
Merged

NeTEx: résultats lus du format binaire #5054

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a4e7507
NeTEx: meilleure sérialisation des résultats
ptitfred Dec 8, 2025
e3591bf
Cleanup old multi_validation.binary_result
ptitfred Dec 11, 2025
c91040e
Test coverage
ptitfred Dec 11, 2025
30e6530
Adjust ResultsAdapter interface
ptitfred Dec 11, 2025
40d8d7b
Test coverage
ptitfred Dec 11, 2025
1a99abd
Dead code
ptitfred Dec 11, 2025
da15589
Validation : stockage binaire des résultats
ptitfred Dec 8, 2025
f425bb4
Merge remote-tracking branch 'mine/netex-validator/binary-results-par…
ptitfred Dec 14, 2025
9c4c392
Drop dead code
ptitfred Dec 14, 2025
f71d5ab
Drop unused index
ptitfred Dec 15, 2025
4c88d0a
Merge remote-tracking branch 'origin/master' into experiments/explore…
ptitfred Dec 15, 2025
8c95964
Merge remote-tracking branch 'origin/master' into experiments/explore…
ptitfred Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust ResultsAdapter interface
  • Loading branch information
@ptitfred
ptitfred committed Dec 11, 2025
commit 30e6530ac8c4c0c80cf0edcb97b464cbb55a3ab2
2 changes: 2 additions & 0 deletions apps/transport/lib/validators/netex/results_adapter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ defmodule Transport.Validators.NeTEx.ResultsAdapter do

@callback summary(map()) :: list()
@callback count_by_severity(map()) :: map()
# DEPRECATED
@callback get_issues(map(), map()) :: list()
@callback get_issues(binary(), map(), Scrivener.Config.t()) :: {pos_integer(), list()}
@callback digest(map()) :: map()
@callback issue_type(list()) :: nil | binary()
@callback format_severity(binary(), non_neg_integer()) :: binary()
Expand Down
4 changes: 4 additions & 0 deletions apps/transport/lib/validators/netex/results_adapters/v0_1_0.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ defmodule Transport.Validators.NeTEx.ResultsAdapters.V0_1_0 do
# DEPRECATED
def get_issues(_, _), do: []

@doc """
Get issues from validation results. For a specific issue type if specified, or the most severe.
"""
@impl Transport.Validators.NeTEx.ResultsAdapter
def get_issues(binary, %{} = filter, %Scrivener.Config{} = pagination_config) when is_binary(binary) do
binary
|> Commons.from_binary()
Expand Down
4 changes: 4 additions & 0 deletions apps/transport/lib/validators/netex/results_adapters/v0_2_0.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ defmodule Transport.Validators.NeTEx.ResultsAdapters.V0_2_0 do
# DEPRECATED
def get_issues(_, _), do: []

@doc """
Get issues from validation results, filtered on category, and paginated.
"""
@impl Transport.Validators.NeTEx.ResultsAdapter
def get_issues(binary, %{} = filter, %Scrivener.Config{} = pagination_config) when is_binary(binary) do
binary
|> Commons.from_binary()
Expand Down
4 changes: 4 additions & 0 deletions apps/transport/lib/validators/netex/results_adapters/v0_2_1.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ defmodule Transport.Validators.NeTEx.ResultsAdapters.V0_2_1 do
# DEPRECATED
def get_issues(_, _), do: []

@doc """
Get issues from validation results, filtered on category, and paginated.
"""
@impl Transport.Validators.NeTEx.ResultsAdapter
def get_issues(binary, %{} = filter, %Scrivener.Config{} = pagination_config) when is_binary(binary) do
binary
|> Commons.from_binary()
Expand Down