Change default keyStepIncrements to 5 #304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the leftRight value was 1, the volume slidebar couldn't be increased due to a floating point error over 28. Setting the value to >1 solved the issue.
|
|
felix-hoc
requested changes
Jun 3, 2024
Contributor
felix-hoc
left a comment
felix-hoc
left a comment
There was a problem hiding this comment.
Increasing the step size would essentially change the behavior. Instead, I'd suggest to fix it by either making sure to return only integers from the Player, or looking into using Math.round() instead of floor(). But we'd have to test it to make sure it doesn't behave weirdly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default keyStepIncrements to 5