Skip to content

[HttpClient] Fix PHP deprecation when using AmpHttpClient #62706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Dec 10, 2025
Merged

[HttpClient] Fix PHP deprecation when using AmpHttpClient #62706

nicolas-grekas merged 1 commit into from
Dec 10, 2025

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 9, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

The deprecation happens when max_duration becomes a float in AsyncContext::replaceRequest().

@carsonbot carsonbot added this to the 6.4 milestone Dec 9, 2025
@OskarStark OskarStark changed the title [HttpClient] Fix PHP deprecation when using AmpHttpClient [HttpClient] Fix PHP deprecation when using AmpHttpClient Dec 9, 2025
@nicolas-grekas nicolas-grekas merged commit 45d7ec5 into symfony:6.4 Dec 10, 2025
11 checks passed
@nicolas-grekas nicolas-grekas deleted the hc-amp-ceil branch December 10, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug HttpClient Status: Needs Review

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas @carsonbot