bug #62706 [HttpClient] Fix PHP deprecation when using AmpHttpClient (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 45d7ec5dc916 · 2025-12-10T11:23:12.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Fix PHP deprecation when using `AmpHttpClient` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT The deprecation happens when max_duration becomes a float in `AsyncContext::replaceRequest()`. Commits ------- 7026f9a [HttpClient] Fix PHP deprecation when using AmpHttpClient
diff --git a/src/Symfony/Component/HttpClient/AmpHttpClient.php b/src/Symfony/Component/HttpClient/AmpHttpClient.php
@@ -133,9 +133,9 @@ public function request(string $method, string $url, array $options = []): Respo
             $request->addHeader($h[0], $h[1]);
         }
 
-        $request->setTcpConnectTimeout(1000 * $options['timeout']);
-        $request->setTlsHandshakeTimeout(1000 * $options['timeout']);
-        $request->setTransferTimeout(1000 * $options['max_duration']);
+        $request->setTcpConnectTimeout(ceil(1000 * $options['timeout']));
+        $request->setTlsHandshakeTimeout(ceil(1000 * $options['timeout']));
+        $request->setTransferTimeout(ceil(1000 * $options['max_duration']));
         if (method_exists($request, 'setInactivityTimeout')) {
             $request->setInactivityTimeout(0);
         }

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,9 @@ public function request(string $method, string $url, array $options = []): Respo`
`133`	`133`	`$request->addHeader($h[0], $h[1]);`
`134`	`134`	`}`
`135`	`135`
`136`		`- $request->setTcpConnectTimeout(1000 * $options['timeout']);`
`137`		`- $request->setTlsHandshakeTimeout(1000 * $options['timeout']);`
`138`		`- $request->setTransferTimeout(1000 * $options['max_duration']);`
	`136`	`+ $request->setTcpConnectTimeout(ceil(1000 * $options['timeout']));`
	`137`	`+ $request->setTlsHandshakeTimeout(ceil(1000 * $options['timeout']));`
	`138`	`+ $request->setTransferTimeout(ceil(1000 * $options['max_duration']));`
`139`	`139`	`if (method_exists($request, 'setInactivityTimeout')) {`
`140`	`140`	`$request->setInactivityTimeout(0);`
`141`	`141`	`}`