[FrameworkBundle] Enable console profiling only if the console is actually available #62692
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
dbu
referenced
this pull request
Dec 8, 2025
4 tasks
Member
|
Can you rebase for 7.4? The method call is missing there also. |
Contributor
Author
in 7.4 we check for the (deprecated) CliRequest::class i guess removing references to the deprecated class was the reason for this regression. i think i would leave 7.4 as is, it works fine. but if you prefer, i can do a PR against 7.4 to replace the class_exists check with a hasConsole call. |
Member
|
I'd keep both calls on 7.4: hasMethod because the method is protected so that it's a possible extension point, and class_exists as a feature test |
dbu
force-pushed
the
profile-console-optional
branch
from
dfff0df to
855e836
Compare
this fixes a regression introduced in ea5a3cc
dbu
force-pushed
the
profile-console-optional
branch
from
855e836 to
5ab5322
Compare
Contributor
Author
|
okay, i target 7.4 now. there will be a conflict when merging up to 8.0 |
nicolas-grekas
approved these changes
Dec 8, 2025
xabbuh
reviewed
Dec 8, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
xabbuh
approved these changes
Dec 8, 2025
GromNaN
changed the title
GromNaN
approved these changes
Dec 8, 2025
Member
|
Thank you @dbu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FrameworkExtension is generally aware that symfony/console is an optional dependency, but when the profiler is loaded, it loads the console profiler unconditionally. this has been broken when the check for CliRequest::class was removed but not replaced with an other check for availability of the console