bug #62692 [FrameworkBundle] Enable console profiling only if the console is actually available (dbu)

nicolas-grekas · nicolas-grekas · commit 13a5dd233411 · 2025-12-10T11:18:09.000+01:00
This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] Enable console profiling only if the console is actually available | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT The FrameworkExtension is generally aware that symfony/console is an optional dependency, but when the profiler is loaded, it loads the console profiler unconditionally. this has been broken [when the check for CliRequest::class was removed](ea5a3cc) but not replaced with an other check for availability of the console Commits ------- 5ab5322 only load console profiling if console is actually available
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -646,7 +646,7 @@ public function load(array $configs, ContainerBuilder $container): void
             $this->registerNotifierConfiguration($config['notifier'], $container, $loader, $this->readConfigEnabled('webhook', $container, $config['webhook']));
         }
 
-        // profiler depends on form, validation, translation, messenger, mailer, http-client, notifier, serializer being registered
+        // profiler depends on form, validation, translation, messenger, mailer, http-client, notifier, serializer being registered. console is optional
         $this->registerProfilerConfiguration($config['profiler'], $container, $loader);
 
         if ($this->readConfigEnabled('webhook', $container, $config['webhook'])) {
@@ -1078,7 +1078,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
         $container->getDefinition('profiler_listener')
             ->addArgument($config['collect_parameter']);
 
-        if (!$container->getParameter('kernel.debug') || !class_exists(CliRequest::class) || !$container->has('debug.stopwatch')) {
+        if (!$container->getParameter('kernel.debug') || !$this->hasConsole() || !class_exists(CliRequest::class) || !$container->has('debug.stopwatch')) {
             $container->removeDefinition('console_profiler_listener');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -646,7 +646,7 @@ public function load(array $configs, ContainerBuilder $container): void`
`646`	`646`	`$this->registerNotifierConfiguration($config['notifier'], $container, $loader, $this->readConfigEnabled('webhook', $container, $config['webhook']));`
`647`	`647`	`}`
`648`	`648`
`649`		`- // profiler depends on form, validation, translation, messenger, mailer, http-client, notifier, serializer being registered`
	`649`	`+ // profiler depends on form, validation, translation, messenger, mailer, http-client, notifier, serializer being registered. console is optional`
`650`	`650`	`$this->registerProfilerConfiguration($config['profiler'], $container, $loader);`
`651`	`651`
`652`	`652`	`if ($this->readConfigEnabled('webhook', $container, $config['webhook'])) {`
`@@ -1078,7 +1078,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $`
`1078`	`1078`	`$container->getDefinition('profiler_listener')`
`1079`	`1079`	`->addArgument($config['collect_parameter']);`
`1080`	`1080`
`1081`		`- if (!$container->getParameter('kernel.debug') \|\| !class_exists(CliRequest::class) \|\| !$container->has('debug.stopwatch')) {`
	`1081`	`+ if (!$container->getParameter('kernel.debug') \|\| !$this->hasConsole() \|\| !class_exists(CliRequest::class) \|\| !$container->has('debug.stopwatch')) {`
`1082`	`1082`	`$container->removeDefinition('console_profiler_listener');`
`1083`	`1083`	`}`
`1084`	`1084`