Page MenuHomePhabricator
Create Task
Maniphest T393649

UsernameLookup: Update `initialInputValue` prop
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The initialInputValue prop of the Lookup component was deprecated as of Codex v1.12.0 and has been removed as of Codex v2.0.0-rc.1 in favor of the inputValue prop, which is set via v-model. The UsernameLookup component in the PageTriage extension is still using the deprecated prop and should be updated ASAP to prevent an interruption in user experience (the Lookup should still work, but if there's an initial selection, it won't display in the input). Codex v2.0.0-rc.1 will ride the deployment train the week of 2025-05-11.

Please reference the Lookup docs to learn how to use the inputValue prop.

Acceptance criteria

  • Update the UsernameLookup component to use the CdxLookup component's inputValue prop instead of initialInputValue

Details

SubjectRepoBranchLines +/-
UsernameLookup: Update `initialInputValue` propmediawiki/extensions/PageTriagemaster+22 -2
Customize query in gerrit

Event Timeline

AnneT created this task.Wed, May 7, 9:12 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptWed, May 7, 9:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae subscribed.Thu, May 8, 2:32 AM

I assume this is the code in question?

https://gerrit.wikimedia.org/g/mediawiki/extensions/PageTriage/+/3d31a2219561e8aebb962ef2488cd2d3c08c7077/modules/ext.pageTriage.newPagesFeed/components/UsernameLookup.vue#4

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Thu, May 8, 2:32 AM
AnneT added a comment.Thu, May 8, 2:26 PM
In T393649#10803023, @Novem_Linguae wrote:

I assume this is the code in question?

https://gerrit.wikimedia.org/g/mediawiki/extensions/PageTriage/+/3d31a2219561e8aebb962ef2488cd2d3c08c7077/modules/ext.pageTriage.newPagesFeed/components/UsernameLookup.vue#4

Yes, that's correct

jsn.sherman triaged this task as High priority.Thu, May 8, 5:05 PM
jsn.sherman moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.
jsn.sherman subscribed.

getting this in the queue for us to work on ASAP

Kgraessle set the point value for this task to 2.Tue, May 13, 3:09 PM
Kgraessle moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.
DMburugu moved this task from Estimated to Kanban on the Moderator-Tools-Team board.Tue, May 13, 4:06 PM
DMburugu edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
DMburugu raised the priority of this task from High to Unbreak Now!.Tue, May 13, 4:11 PM
Kgraessle claimed this task.Tue, May 13, 4:31 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Tue, May 13, 6:51 PM

Change #1145311 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PageTriage@master] UsernameLookup: Update `initialInputValue` prop

https://gerrit.wikimedia.org/r/1145311

gerritbot added a project: Patch-For-Review.Tue, May 13, 6:51 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Tue, May 13, 7:12 PM
Jdforrester-WMF subscribed.Wed, May 14, 10:06 PM

Given this will be broken in the current train, should it be marked as a train blocker?

Novem_Linguae added a comment.Thu, May 15, 12:21 AM

Seems like a really minor bug to me. I don't think it needs to be a train blocker / don't think it needs a backport. Special:NewPagesFeed still works, it just doesn't auto fill the username text box when filtering by username, then closing and re-opening the filters panel.

Soda subscribed.EditedThu, May 15, 12:53 AM

Agreed, this shouldn't need to block the train

gerritbot added a comment.Thu, May 15, 8:59 PM

Change #1145311 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] UsernameLookup: Update `initialInputValue` prop

https://gerrit.wikimedia.org/r/1145311

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).Thu, May 15, 9:00 PM
Novem_Linguae closed this task as Resolved.Thu, May 15, 9:04 PM
Maintenance_bot removed a project: Patch-For-Review.Thu, May 15, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits