Page MenuHomePhabricator
Create Task
Maniphest T372831

Consider not posting in phab when a patchdemo gets deleted
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
SDunlap
Aug 19 2024, 9:13 PM
Tags
Referenced Files
F60302839: Screenshot_20250520-071544.png
Tue, May 20, 2:17 PM
F60082962: image.png
Fri, May 16, 7:43 PM
F57281837: 02.png
Aug 19 2024, 9:13 PM
F57281835: 01.png
Aug 19 2024, 9:13 PM
Subscribers
Aklapper
Bugreporter
Novem_Linguae
SDunlap
Tacsipacsi

Description

Originally: https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/issues/600

Consider not posting in phab when a patchdemo gets deleted. It creates email noise and phab comment noise on old tickets. I think folks can discover that a patchdemo is deleted when they click on the link and encounter an error message, and that it probably doesn't need a separate notification.

This error message could possibly use improvement though. This is what the user sees when they visit a deleted patch demo:

01.png (608×348 px, 18 KB)

02.png (279×993 px, 15 KB)

Perhaps it can explicitly say if it was deleted?

Details

TitleReferenceAuthorSource BranchDest Branch
includes: don't notify phabricator when deleting a patchdemorepos/test-platform/catalyst/patchdemo!148novemlinguaedont-notify-phab-on-deletemain
Customize query in GitLab

Related Objects

Event Timeline

SDunlap created this task.Aug 19 2024, 9:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2024, 9:13 PM
Bugreporter subscribed.Aug 20 2024, 12:57 AM

Older comments in Phabricator can be edited by its author so the bot may edit the message about creating the instance instead.

thcipriani moved this task from Triage to needs discussion/meta on the Catalyst (PatchDemo) board.Sep 25 2024, 7:34 PM
Novem_Linguae added a comment.Fri, May 16, 7:43 PM

I got a couple more of these today.

image.png (490×431 px, 18 KB)
CodeReviewBot added a project: Patch-For-Review.Fri, May 16, 7:48 PM

novemlinguae opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/148

includes: don't notify phabricator when deleting a patchdemo

Tacsipacsi subscribed.Sat, May 17, 11:23 AM
In T372831#10831279, @Novem_Linguae wrote:

I got a couple more of these today.

Sorry, that was me. It should be a one-time thing, and with the auto-deletion system (T372981) in place, such bursts of deletion should be even rarer in the future than in the past, since wikis will be deleted when patches are merged and tasks are closed (which varies by wiki), not when the server runs out of disk space.

Novem_Linguae added a comment.Tue, May 20, 2:17 PM

Got some more today.

Screenshot_20250520-071544.png (2×1 px, 357 KB)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits