bug #62614 [Cache] Fix NullAdapter must set taggable (a.dmitryuk)

nicolas-grekas · nicolas-grekas · commit 17c71504e909 · 2025-12-02T10:16:44.000+01:00
This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [Cache] Fix NullAdapter must set taggable | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | Fix #...  | License | MIT After PR #61127 merged NullAdapter still doesn't work as taggable. After tagging there is an error ``` Cache item "tag1" comes from a non tag-aware pool: you cannot tag it. ``` Psalm must fail here same as https://github.com/symfony/symfony/blob/8.1/src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php#L69 <img width="1896" height="137" alt="image" src="https://github.com/user-attachments/assets/33fb59d4-b048-495d-950c-005dbbaa3ea0" /> Commits ------- 273f1b7 [Cache] Fix NullAdapter must set taggable
diff --git a/src/Symfony/Component/Cache/Adapter/NullAdapter.php b/src/Symfony/Component/Cache/Adapter/NullAdapter.php
@@ -28,6 +28,7 @@ public function __construct()
         self::$createCacheItem ??= \Closure::bind(
             static function ($key) {
                 $item = new CacheItem();
+                $item->isTaggable = true;
                 $item->key = $key;
                 $item->isHit = false;
 
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/NullAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/NullAdapterTest.php
@@ -138,6 +138,15 @@ public function testCommit()
         $this->assertTrue($this->createCachePool()->commit());
     }
 
+    public function testTaggable()
+    {
+        $this->expectNotToPerformAssertions();
+        $adapter = $this->createCachePool();
+        $item = $adapter->getItem('any_item');
+        // No error triggered 'Cache item "%s" comes from a non tag-aware pool: you cannot tag it.'
+        $item->tag(['tag1']);
+    }
+
     public function testInvalidateTags()
     {
         $adapter = $this->createCachePool();
