-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix: Improve Solr query stability for languages and subjects #11552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
saifxyzyz
wants to merge
28
commits into
internetarchive:master
Choose a base branch
from
saifxyzyz:fix-downtime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…availability`, including cache behavior.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
I've been trying to get the python_tests to pass but my test_verification.py file makes it fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Closes #11546
[Fix]
Technical
Changes:
_pass_time_allowed=Trueto the Solr query inget_all_language_counts, this makes Solr return the partial results it has collected so far instead of crashing.publish_yearfacet limit from -1 to 2000 inSubjectEngine, this makes sure Solr returns the top 2000 most common years which covers up all legitimate historical years while filtering out dirty data like typos or invalid years which would cause performance issuesTesting
Ran automated tests (
openlibrary/plugins/worksearch/tests/test_worksearch.py)Created a custom script (
openlibrary/plugins/worksearch/tests/test_verification.py) to mock solr and verify that the new parameters are correctly passedpartialResults: Trueand confirmed thatget_all_language_countsreturns the available data instead of raising an exception._pass_time_allowed=Trueis explicitly passed in the Solr query parameters.publish_yearfacet request includeslimit: 2000.Screenshot
Stakeholders