gh-144433: clarify patch.dict behavior #144434
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update wording to indicate that unittest.mock patch.dict will make a shallow copy of the patched dict (opposed to a deep copy)
Member
|
Most of the time we use "copy" for "shallow" copy as opposed to "deep" copy which is usually mentioned. However, since this is the only occurrence of that in this page, I guess it's also fine. Can you check if there are other places in the unittest docs that require this improvement? (better do it in one go). Also can you also update the RST docs? it's much more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update wording to indicate that unittest.mock patch.dict will make a shallow copy of the patched dict (opposed to a deep copy)