-
Notifications
You must be signed in to change notification settings - Fork 75
Remove TunableGroups from Storage classes and add TrialData tests #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
motus
merged 11 commits into
microsoft:main
from
bpkroth:remove-tunables-from-storage-classes
Jan 23, 2024
Merged
Remove TunableGroups from Storage classes and add TrialData tests #644
motus
merged 11 commits into
microsoft:main
from
bpkroth:remove-tunables-from-storage-classes
Jan 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work split out from microsoft#633 - Reorgs the unit test fixtures for reuse by mlos_viz (future PR) - Removes TunablesGroups from Storage classes. Currently unnecessary, belongs in Experiment, and causes inconsistencies with ExperimentData interactions. - Adjusts the initialization code to match.
motus
reviewed
Jan 19, 2024
bpkroth
commented
Jan 22, 2024
motus
approved these changes
Jan 23, 2024
bpkroth
added a commit
that referenced
this pull request
Jan 23, 2024
…rty for `TrialData` and `ExperimentData` (#648) Useful for grouping trials by the config they used. In use by upcoming #633 for generating graphs with variance error bars for repeated configs. Also refactors a number of other things: - Standardize on `experiment_id` instead of `exp_id` (but not the db schema for now) - Standardize on `tunable_config_id` instead of `config_id` in the API since we also call it `tunable_config` for the object fetching property to distinguish from the `config` dict used internally. (but not the db schema for now) - Rework the idea of `TunableConfigTrialGroup` as an object inaddition to an ID (further methods can be added later to move back and forth between types when doing interactive analysis). - Rework the idea of a `TunableConfig` as an object for fetching tunable value assignments (similar justification - easier grouping in the future by fetching trial across experiments based on config - eventually could be used to house the experiment merge logic). - Rename `results` APIs to `results_df` (similar for others that return `pandas.DataFrame`) to match the `results_dict` that return `dict` - Refactor test fixtures to match other styles and for future use (moved to #644). - Expand tests NOTE: - We cut a new version with this commit since there are potentially breaking API changes (e.g., `results` -> to `results_df` and `exp_id` -> `experiment_id`). Currently builds off of #644 and splits work out of #633 --------- Co-authored-by: Sergiy Matusevych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work split out from #633