Skip to content

Fix safeFilename function to hash input to prevent leaking sensitive data to filesystem #27

@panekj

Description

@panekj

Using uses: https://${{ secrets.USER }}:${{ secrets.PASS }}@host.tld/repo.git will leak credentials as plaintext to filesystem via actions cache

actionDir := fmt.Sprintf("%s/%s", sar.RunContext.ActionCacheDir(), safeFilename(sar.Step.Uses))

https://gitea.com/gitea/act/pulls/117/files
https://gitea.com/pj/act/commit/b6450c7f71210cf9988deae3a84d41efb28eae77

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions