adapter: sort catalog entries into topo order in bootstrap #34859
+125
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds topological sorting of catalog entries to the coordinator bootstrap process. Previously, we were only sorting by catalog IDs, but ID order doesn't always match dependency order nowadays, and it is important that the entries are bootstrapped in dependency order. In the sorting we treat indexes specially, to ensure they get created as early as possible. This makes sure any object depending on an indexed relation is also able to make use of the index. To avoid code duplication, this commit pulls out the existing topo sort implementation from `apply.rs` into a util module and makes it generic.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds topological sorting of catalog entries to the coordinator bootstrap process. Previously, we were only sorting by catalog IDs, but ID order doesn't always match dependency order nowadays, and it is important that the entries are bootstrapped in dependency order.
In the sorting we treat indexes specially, to ensure they get created as early as possible. This makes sure any object depending on an indexed relation is also able to make use of the index. On main, this change reduces the number of dataflow operators in mz_catalog_server from 11863 to 9948 and the number of arrangements from 842 to 763.
To avoid code duplication, this PR pulls out the existing topo sort implementation from
apply.rsinto a util module and makes it generic.Motivation
mz_catalog_server has a bunch of dataflows that don't make use of available indexes. Slack thread.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.