QL/RB: delete language specific codeql query compile checks #11328
+0
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
reviewed
Nov 18, 2022
| @@ -33,11 +33,6 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: ./.github/actions/fetch-codeql | |||
| - name: Check QL compilation | |||
There was a problem hiding this comment.
Let's delete the entire qlcompile job.
codeql/.github/workflows/ruby-qltest.yml
Lines 31 to 40 in e777934
aibaars
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We now have a combined workflow that does the same thing for all languages in one go, and which does it faster (thanks to caching).
ATM still have their specific compilation check as their queries aren't covered by the combined workflow.
ATM queries have compilation warnings by design, so the combined workflow cannot work for their queries.