The Wayback Machine - https://web.archive.org/web/20220220221801/https://github.com/NativeScript/NativeScript/pull/9606
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrate): apps/* to webpack5 #9606

Merged
merged 12 commits into from Dec 21, 2021
Merged

chore(migrate): apps/* to webpack5 #9606

merged 12 commits into from Dec 21, 2021

Conversation

@rigor789
Copy link
Member

@rigor789 rigor789 commented Oct 10, 2021

Some tests in apps/automated have been commented out because they test WeakRef implementation details - with the update to the latest v8 runtimes, we are now using the built-in WeakRef implementation, and it does not guarantee releases after a GC pass, it uses heuristics to release when necessary - so any tests that check if something is released are flaky and unreliable.

A few more tests are failing, still investigating the cause.

@cla-bot cla-bot bot added the cla: yes label Oct 10, 2021
@NathanWalker NathanWalker added this to the 8.2 milestone Oct 21, 2021
@NathanWalker NathanWalker force-pushed the feat/webpack5-migration branch from de9d136 to ab3a288 Dec 18, 2021
@NathanWalker NathanWalker marked this pull request as ready for review Dec 21, 2021
@NathanWalker NathanWalker merged commit a88caca into master Dec 21, 2021
1 of 2 checks passed
@NathanWalker NathanWalker deleted the feat/webpack5-migration branch Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants