The Wayback Machine - https://web.archive.org/web/20201023163734/https://github.com/angular/angular-cli/pull/18847

angular / angular-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): add Webpack 5 to peer dependencies #18847

Open

valorkin wants to merge 1 commit into angular:master from valorkin:chore-ngtools-webpack-dep

+2 −2

Contributor

valorkin commented Sep 22, 2020

Very minor addition to #18820
adding optional webpack@5 to peer dependencies of ngtools/webpack

googlebot added the cla: yes label

valorkin force-pushed the valorkin:chore-ngtools-webpack-dep branch from e99fc4d to 6d8d63d

alan-agius4 reviewed

packages/ngtools/webpack/package.json Outdated

  
      @@ -28,7 +28,7 @@
    
          "peerDependencies": {

            "@angular/compiler-cli": "^11.0.0 || ^11.0.0-next",

            "typescript": ">=3.9 < 4.1",

            "webpack": "^4.0.0"

            "webpack": "^4.0.0 || ^5.0.0"

alan-agius4 Sep 22, 2020
Collaborator

Webpack version 5 is not yet stable thus the semver version here is invalid. It should be `^5.0.0-rc.0`.

Chiming in @clydin just to confirm whether we should add this `peerDependencies` in the first place since Webpack 5 support is still experimental, and adding Webpack 5 might send out the wrong message.

alan-agius4 Sep 22, 2020
Collaborator

PS: `chore` is an invalid commit message type. You can use `fix` for this.

`fix(@ngtools/webpack): add Webpack 5 to peer dependencies`

valorkin Sep 22, 2020
Author Contributor

I know, just made it the same way as it appears in all other occurrences. I can change those to rc.0 too

valorkin Sep 22, 2020
Author Contributor

all comments applied

valorkin force-pushed the valorkin:chore-ngtools-webpack-dep branch from 6d8d63d to 665e999

alan-agius4 requested a review from clydin

valorkin changed the title ~~chore(@ngtools/webpack): minor fix to dependency to support ^5~~ fix(@ngtools/webpack): minor fix to dependency to support ^5


          fix(@ngtools/webpack): add Webpack 5 to peer dependencies

878ebc1

valorkin force-pushed the valorkin:chore-ngtools-webpack-dep branch from 665e999 to 878ebc1

valorkin changed the title ~~fix(@ngtools/webpack): minor fix to dependency to support ^5~~ fix(@ngtools/webpack): add Webpack 5 to peer dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.