The Wayback Machine - https://web.archive.org/web/20201026171425/https://github.com/github/VisualStudio/pull/2460
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign the VSIX #2460

Merged
merged 8 commits into from Mar 28, 2020
Merged

Sign the VSIX #2460

merged 8 commits into from Mar 28, 2020

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Feb 19, 2020

What this PR does

  • Use vsixsigntool.exe to sign the VSIX
  • Only sign master branch builds
  • Update the certificate /sha1
  • Include certificate.pfx with the source
  • Include vsixsigntool.exe in tools folder (from Microsoft.VsSdk.VsixSignTool, v16.2.29116.78)

image

Notes

I used the following command to find /sha1 9c5a6d389e1454f2ed9ee9419cdf743689709f9c for vsixsigntool.exe:

> certutil -p PASSWORD -dump .\certificate.pfx
================ Certificate 0 ================
================ Begin Nesting Level 1 ================
Element 0:
Serial Number: 0409181b5fd5bb66755343b56f955008
Issuer: CN=DigiCert Assured ID Root CA, OU=www.digicert.com, O=DigiCert Inc, C=US
 NotBefore: 22/10/2013 12:00 PM
 NotAfter: 22/10/2028 12:00 PM
Subject: CN=DigiCert SHA2 Assured ID Code Signing CA, OU=www.digicert.com, O=DigiCert Inc, C=US
Non-root Certificate
Cert Hash(sha1): 92c1588e85af2201ce7915e8538b492f605b80c6
----------------  End Nesting Level 1  ----------------
No key provider information
Cannot find the certificate and private key for decryption.

================ Certificate 1 ================
================ Begin Nesting Level 1 ================
Element 1:
Serial Number: 09144b52c8330f257d2512daaaa1e545
Issuer: CN=DigiCert SHA2 Assured ID Code Signing CA, OU=www.digicert.com, O=DigiCert Inc, C=US
 NotBefore: 05/02/2020 12:00 AM
 NotAfter: 09/02/2023 12:00 PM
Subject: CN=GitHub, Inc., O=GitHub, Inc., L=San Francisco, S=California, C=US
Non-root Certificate
Cert Hash(sha1): 9c5a6d389e1454f2ed9ee9419cdf743689709f9c
----------------  End Nesting Level 1  ----------------
  Provider = Microsoft Enhanced Cryptographic Provider v1.0
Encryption test passed
CertUtil: -dump command completed successfully.
jcansdale added 7 commits Mar 28, 2020
Found using: certutil -p PASSWORD -dump .\certificate.pfx
@jcansdale jcansdale changed the title Update certificate SHA1 Sign the VSIX Mar 28, 2020
@jcansdale jcansdale merged commit 8c5f0cf into master Mar 28, 2020
2 checks passed
2 checks passed
build
Details
github.VisualStudio #2.11.95+461208ac17 succeeded
Details
@jcansdale jcansdale deleted the azure-pipelines/certificate-sha1 branch Mar 28, 2020
@github github deleted a comment Aug 5, 2020
@github github deleted a comment Aug 5, 2020
@github github deleted a comment Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.