Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Pull request comments not visible inline for VS2017 #2542
Comments
|
I have the same issue with both Visual Studio 2017 Pro and 2019 Pro. GitHub Extension v2.11.106.19330 Not sure how to set the priority of this issue (as I am relatively new to GitHub), but this is hitting the productivity of our code review big time. |
|
This seems to occur when a user makes posts a comment directly on the GitHub website. |
|
@dtuckerFort One collaborator and I myself post comments through the Visual Studio's GitHub extension, but I think another collaborator used the website to post comment too. |
|
It doesn't work with inline comments also... I created some comment when I was reviewing PR changes and it appeared on GitHub website without any problems but clicking it on Reviews subtab in GitHub extension(tab) resulted in providing the same error as usual. At the moment it's just useless ... :(
|
Versions
What happened
The GitHub plugin let's me add a pull-request comment inline but doesn't show any comments inline. Comments are only visible within the Reviewer view. My teammates have the same problem. Sometimes it works, sometimes it doesn't
extension.log when clicking link to open PR comment:
2020-09-03 17:05:41.240 [43780] EROR [01] PullRequestDetailViewModel Error loading pull request [local git repo]
System.NullReferenceException: Object reference not set to an instance of an object.
at GitHub.ViewModels.GitHubPane.PullRequestDetailViewModel.d__111.MoveNext() in C:\projects\visualstudio\src\GitHub.App\ViewModels\GitHubPane\PullRequestDetailViewModel.cs:line 0
2020-09-03 17:12:06.123 [07420] EROR [61] PullRequestSessionManager
System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.
at GitHub.InlineReviews.Services.PullRequestSessionService.d__24.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionService.cs:line 368
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__18.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 249
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__17.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 214
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__16.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 193
--- End of inner exception stack trace ---
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
at GitHub.InlineReviews.Services.PullRequestSessionService.d__24.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionService.cs:line 368
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__18.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 249
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__17.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 214
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at GitHub.InlineReviews.Services.PullRequestSessionManager.d__16.MoveNext() in C:\projects\visualstudio\src\GitHub.InlineReviews\Services\PullRequestSessionManager.cs:line 193<---
extension.log when clicking link to a closed PR comment:
"PullRequestReviewCommentViewModel Couldn't find line number for comment on"
This seems to occur when a user makes posts a comment directly on the GitHub website.
The text was updated successfully, but these errors were encountered: