C#: Add support for custom assert methods (DoesNotReturnIfAttribute) #4484
Conversation
tamasvajk
force-pushed
the
feature/custom-assert-methods
branch
2 times, most recently
from
585fd15 to
599f5bd
Compare
tamasvajk
force-pushed
the
feature/custom-assert-methods
branch
from
599f5bd to
52bdd8b
Compare
tamasvajk
changed the title
tamasvajk
changed the title
tamasvajk
force-pushed
the
feature/custom-assert-methods
branch
7 times, most recently
from
9182cf7 to
52bdd8b
Compare
|
|
||
| override Class getExceptionClass() { | ||
| // The user defines the thrown exception. | ||
| any() |
There was a problem hiding this comment.
This creates a large Cartesian product, so better to return the System.Exception base class.
| override predicate hasEntry(ControlFlowElement pred, ControlFlowElement succ, Completion c) { | ||
| exists(AssertMethod m | | ||
| pred = last(a.getExpr(), c) and | ||
| pred = last(a.getAnExpr(), c) and |
There was a problem hiding this comment.
The CFG splitting logic will not work for assertions with multiple assertion arguments; I will address in a follow-up PR.
There are some nice fixes in the results, for example, we're not reporting on the following that it can be null: https://github.com/dotnet/runtime/blob/45833cb6e43b481cdb1dabe2ce29fca48ee7bf6a/src/libraries/System.Linq.Expressions/src/System/Dynamic/DynamicObject.cs#L465 |
That's excellent! |
2 participants
No description provided.