The Wayback Machine - https://web.archive.org/web/20201023141148/https://github.com/nodejs/node/pull/35760
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] doc: update fs promise-based examples #35760

Open
wants to merge 1 commit into
base: v12.x-staging
from

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Oct 22, 2020

#34843 was cherry-picked onto
v12.x-staging in 961844d but the fs/promises API, as used
in the examples, is only available from Node.js 14. Change the
added examples to use require(fs).promises instead.

Fixes: #35740
Refs: #34843

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
#34843 was cherry-picked onto
`v12.x-staging` in 961844d but the `fs/promises` API, as used
in the examples, is only available from Node.js 14. Change the
added examples to use `require(fs).promises` instead.
@richardlau richardlau force-pushed the richardlau:fsdocs branch from e7697fb to 10fa5de Oct 22, 2020
@richardlau richardlau changed the title [12.x] doc: update fs.promises examples [12.x] doc: update fs promise-based examples Oct 22, 2020
@aduh95
aduh95 approved these changes Oct 22, 2020
@lpinca
lpinca approved these changes Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.