The Wayback Machine - https://web.archive.org/web/20201023141213/https://github.com/nodejs/node/pull/35758
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: ignore GCC -Wcast-function-type for v8.h" #35758

Open
wants to merge 1 commit into
base: master
from
Open

Revert "src: ignore GCC -Wcast-function-type for v8.h" #35758

wants to merge 1 commit into from
+0 −14

Conversation

@danbev
Copy link
Member

@danbev danbev commented Oct 22, 2020

This reverts commit f21cf45 as this has
now been included in the V8 version being used.

Refs:
v8/v8@f08cbfd

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
Revert "src: ignore GCC -Wcast-function-type for v8.h"
Loading status checks…
b9aa368 
This reverts commit f21cf45 as this has
now been included in the V8 version being used.

Refs:
v8/v8@f08cbfd
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Oct 22, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33800/
@richardlau
richardlau approved these changes Oct 22, 2020
View changes
@cjihrig
cjihrig approved these changes Oct 22, 2020
View changes
@targos
targos approved these changes Oct 22, 2020
View changes
@richardlau
Copy link
Member

@richardlau richardlau commented Oct 22, 2020

Looks like v8/v8@f08cbfd is on V8 8.5 and above so adding appropriate dont-land-on-v* labels.
@gireeshpunathil
gireeshpunathil approved these changes Oct 22, 2020
View changes
@lundibundi
lundibundi approved these changes Oct 22, 2020
View changes
@addaleax
Copy link
Member

@addaleax addaleax commented Oct 22, 2020

Can we also revert 3ff2aec?
@devnexen
devnexen approved these changes Oct 22, 2020
View changes
@danbev
Copy link
Member Author

@danbev danbev commented Oct 22, 2020 •
edited

Can we also revert 3ff2aec?

Yep, we should revert that too. Sorry I forgot about it completely. I'll create a revert for it too. Thanks!
Opened #35768 to remove the rest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos

@cjihrig cjihrig

@devnexen devnexen

@richardlau richardlau

@gireeshpunathil gireeshpunathil

@lundibundi lundibundi

Assignees
No one assigned
Labels
C++ buffer dont-land-on-v10.x dont-land-on-v12.x dont-land-on-v14.x
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@danbev @nodejs-github-bot @richardlau @addaleax @targos @cjihrig @devnexen @gireeshpunathil @lundibundi
You can’t perform that action at this time.