Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uputil: remove instance check on empty object #35754
Open
+13
−2
Conversation
Remove a useless check on Object descriptor. It seems like js browsers engine dont do this check. Fixes: #35730
Remove a useless check on Object descriptor. It seems like js browsers engine dont do this check. Fixes: #35730
|
Hi @baylesa-dev |
Write test to prevent this bug in future
Codecov Report
@@ Coverage Diff @@
## master #35754 +/- ##
==========================================
- Coverage 87.92% 87.85% -0.07%
==========================================
Files 477 477
Lines 113090 113088 -2
Branches 24632 24606 -26
==========================================
- Hits 99431 99356 -75
- Misses 7948 8020 +72
- Partials 5711 5712 +1
|
|
@aduh95 Do you know why some checks weren't successful ? What could I do to resolve them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Remove a useless check on Object descriptor. It seems like js browsers engine dont do this check.
Fixes: #35730
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes