The Wayback Machine - https://web.archive.org/web/20201023163214/https://github.com/angular/angular-cli/issues/18465
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different tslint typedef behavior between migration and generation #18465

Open
Bored-Bohr opened this issue Aug 6, 2020 · 0 comments
Open

Different tslint typedef behavior between migration and generation #18465

Bored-Bohr opened this issue Aug 6, 2020 · 0 comments

Comments

@Bored-Bohr
Copy link

@Bored-Bohr Bored-Bohr commented Aug 6, 2020

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

When migrating from Angular 9 using ng update @angular/core @angular/cli the typedef rule is not added to tslint.json.
When generating a new project in Angular 10, the typedef rule is added.

It seems that typedef should be added with Angular 10 #17821

🔬 Minimal Reproduction

Migration

  1. Install Angular CLI 9: npm i -g @angular/cli@v9-lts
  2. Generate Angular 9: ng new <project_name>
  3. cd <project_name>
  4. Update to Angular 10: ng update @angular/core @angular/cli

Generation

  1. Install Angular CLI 9: npm i -g @angular/cli@latest
  2. Generate Angular 10: ng new <project_name>

Check difference in tslint.json

🌍 Your Environment

Angular CLI: 9.1.12
Node: 12.18.3
OS: win32 x64

Angular CLI: 10.0.5
Node: 12.18.3
OS: win32 x64

Anything else relevant?

@ngbot ngbot bot modified the milestone: Backlog Aug 6, 2020
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 6, 2020
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 6, 2020
@ngbot ngbot bot modified the milestone: Backlog Aug 6, 2020
@ngbot ngbot bot added this to the needsTriage milestone Aug 10, 2020
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes angular#18465
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes angular#18465
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes angular#18465
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes angular#18465
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 11, 2020
@alan-agius4 alan-agius4 modified the milestones: Backlog, V11-candidates Aug 11, 2020
@alan-agius4 alan-agius4 self-assigned this Aug 14, 2020
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 27, 2020
With this change we add a migration to add the `typedef` tslint rule. Since this rule doesn't come with an fixer, the migratioin will add a comment to disable tslint line on the next line when we find possible linting failures.

Closes angular#18465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.