The Wayback Machine - https://web.archive.org/web/20201008214223/https://github.com/TheAlgorithms/Python/pull/2944
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add molecular_chemistry.py #2944

Open
wants to merge 7 commits into
base: master
from
Open

Add molecular_chemistry.py #2944

wants to merge 7 commits into from

Conversation

@prakhargurunani
Copy link

@prakhargurunani prakhargurunani commented Oct 6, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@prakhargurunani
Create molecular_chemistry.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d54b769
@prakhargurunani
round up outputs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7b3758d
@prakhargurunani
Remove floating point
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a01a3c
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 6, 2020

@cclauss @poyea Please see this. #2765 is merged but I am still getting a pre-commit error. All tests have passed.
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 6, 2020 •
edited

There are 200+ open pull requests on this repo. Please do not @mention maintainers on your pull request because you believe that it is more important than the others. We have our hands full with the silliness of Hacktoberfest and this is not something that we are paid to do.
@prakhargurunani prakhargurunani mentioned this pull request Oct 6, 2020
Open
0 of 2 tasks complete
prakhargurunani and others added 2 commits Oct 7, 2020
@prakhargurunani
Add Wikipedia references
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b460da4
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
965e85a
@github-actions github-actions bot force-pushed the prakhargurunani:add/mol-chem branch from 4cf7729 to 965e85a Oct 7, 2020
prakhargurunani and others added 2 commits Oct 7, 2020
@prakhargurunani
Add Conversions/Molecular Chemistry
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
474de77
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
c376941
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 7, 2020 •
edited

@poyea @dhruvmanila All checks and actions have passed. Please merge.

Can you also add hacktoberfest-accepted label to this PR ?
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 7, 2020

I think this looks good @dhruvmanila . Can you give a review about it ?
@cclauss
cclauss requested changes Oct 7, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment •
edited

Is this submission also plagiarism like #2983 (comment) was?
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 7, 2020 •
edited by cclauss

No...this is my own code
@NicholasACTran
Copy link

@NicholasACTran NicholasACTran commented Oct 8, 2020

Ignoring whether this is plagiarism or not, does this count as an "algorithm" in the computer science theoretic sense?
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 8, 2020

Ignoring whether this is plagiarism or not, does this count as an "algorithm" in the computer science theoretic sense?

@NicholasACTran There are also temperature conversion in conversions. This PR also belongs to the same category. And this is NOT plagiarised.
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 8, 2020

@NicholasACTran Our barrier is purposefully low on evaluating if contributions count as an algorithm in the computer science theoretic sense because that line is difficult to draw and because we are attempting to attract contributions from people who are not (yet) computer science experts.
@NicholasACTran
Copy link

@NicholasACTran NicholasACTran commented Oct 8, 2020 •
edited

Thanks for the clarification.
@prakhargurunani
Copy link
Author

@prakhargurunani prakhargurunani commented Oct 8, 2020 •
edited by dhruvmanila

So will you merge this ?
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 8, 2020

As mentioned please don't @mention maintainers. We already have hundreds of PRs to go through so have patience and we will take a look at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@prakhargurunani @cclauss @NicholasACTran @dhruvmanila
You can’t perform that action at this time.