Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
feat: add shell.cmd to replace exec #866
Conversation
|
Apparently newlines are always converted to Windows has a separate issue with executing |
|
It turns out that Windows poses an extra issue. |
|
Currently investigating Windows behavior on branch |
|
would this fix the security issue described here? embarklabs/embark#1329 |
|
Hi all! I would like to clarify: this pull request adds a new feature to our module. It is not a security fix.
|
|
Thank you for the clarification @nfischer and your hard work! |
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 97.14% 97.22% +0.07%
==========================================
Files 34 35 +1
Lines 1298 1332 +34
==========================================
+ Hits 1261 1295 +34
Misses 37 37
Continue to review full report at Codecov.
|
This adds an initial implementation of shell.cmd(), which is intended as the eventual replacement for shell.exec(). This PR does not fully implement the API, but demonstrates a simple and secure alternative, and will allow further iteration to cover other use cases in follow-up PRs. Design doc: https://shelljs.page.link/cmd-design Issue #495 Test: automated test suite
nfischer
dismissed
freitagbr’s
stale review
freitagbr is no longer active with the project
This adds an initial implementation of shell.cmd(), which is intended as
the eventual replacement for shell.exec(). This PR does not fully
implement the API, but demonstrates a simple and secure alternative, and
will allow further iteration to cover other use cases in follow-up PRs.
Design doc: https://shelljs.page.link/cmd-design
Issue #495
Test: automated test suite