The Wayback Machine - https://web.archive.org/web/20201011182843/https://github.com/JSQLParser/JSqlParser/pull/1045
Skip to content

/ JSqlParser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation visitor framework #1045

Open
wants to merge 263 commits into
base: master
from
Open

Validation visitor framework #1045

wants to merge 263 commits into from
+9,189 −81

Conversation

@gitmotte
Copy link
Contributor

@gitmotte gitmotte commented Sep 11, 2020 •
edited

#1005

extensible validation visitor framework
add (package net.sf.jsqlparser.util.validation)

  • an extensible validation visitor framework: ValidationCapability and its subtypes
    • FeatureSetValidation,
    • DatabaseMetaDataValidation,
    • AllowedTypesValidation

add (package net.sf.jsqlparser.parser.feature)

  • FeatureConfiguration class : common way for configurations of parser-features (supports Object-values - with convenience methods for boolean getAsBoolean, String getAsString)
  • Feature/FeatureSet classes : jsqlparser features which can be collected in featuresets

changes in branch https://github.com/gitmotte/JSqlParser/tree/master.validate within packages

  • net.sf.jsqlparser.util.validation
  • net.sf.jsqlparser.parser.feature
gitmotte added 30 commits Jul 6, 2020
@gitmotte
Merge branch 'master.fluent' of https://github.com/gitmotte/JSqlParse…
4b3a1a4 
…r.git into master.fluent
@gitmotte
* add with prefix for fluent setters.
34db4f5 
 #1004
@gitmotte
add getters
a2600c7
@gitmotte
* add with prefix for fluent setters. (revert to chaining setters, do
bb2b15f 
not break current api)

 #1004
@gitmotte
* add with prefix for fluent setters. (revert to chaining setters, do
8b6fd6b 
not break current api)

 #1004
@gitmotte
use new methods within testcases
0880fde
@gitmotte
use new methods within testcases
63679e0
@gitmotte
use new methods within testcases
1d0a24d
@gitmotte
use new methods within testcases
fda2f67
@gitmotte
use new methods within testcases
8d2cde4
@gitmotte
use new methods within testcases
1027829
@gitmotte
use new methods within testcases
8de6c09
@gitmotte
use new methods within testcases
a0cc175
@gitmotte
Merge branch 'master.fluent' of
dd60c2e 
https://github.com/gitmotte/JSqlParser.git into master.fluent
@gitmotte
remove create() methods - they do not add enough value to be justified
ea4356a
@gitmotte
* use new methods within testcases
8ece698 
* add some constructors
* fix and add "with" / "add" methods
@gitmotte
* use new methods within testcases
77d92c0
@gitmotte
* use new methods within testcases
0c99e8c 
* add some constructors
@gitmotte
* renamed constant
89fe5f4
@gitmotte
use new methods within testcases
4d94a4d
@gitmotte
use new methods within testcases
d2cec9d
@gitmotte
use new methods within testcases
0554831
@gitmotte
use new methods within testcases
b55b988
@gitmotte
Merge branch 'master.fluent' of https://github.com/gitmotte/JSqlParse…
8b68980 
…r.git into master.fluent
@gitmotte
* use new methods within testcases
5f10ac4 
* add some with-methods
* add getter/setter named after the field without abbrivation
@gitmotte
* use new methods within testcases
a7a0b70
@gitmotte
remove empty implicit constructor
77cf290
@gitmotte
return the deparsed Statement - object
09691fe
@gitmotte
compare object tree
d0c12d6
@gitmotte
compare object tree
06684c1
gitmotte added 10 commits Sep 22, 2020
@gitmotte
extract JdbcDatabaseMetaDataCapability.splitAndValidateMinMax
df60604
@gitmotte
add pivot/unpivot/pivotxml validation testcases
0ec87ef
@gitmotte
add testcase for Feature.tableFunction
b8bbe8f
@gitmotte
add test for lateral joins and subjoins
Loading status checks…
b1c094d
@gitmotte
add testValidationRowMovementOption
e8209a7
@gitmotte
add values validator test
0ac4006
@gitmotte
move tests to LimitValidatorTest
5c2b65d
@gitmotte
move tests to UseStatementValidatorTest
457d17b
@gitmotte
add tests for SET - statements
5eb08ec
@gitmotte
fix checkstyle error
Loading status checks…
5bec08a
@gitmotte gitmotte changed the title WIP: Validation visitor framework Validation visitor framework Sep 22, 2020
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Sep 22, 2020

@wumpz i think the next steps, bugfixes or features should be developed with new pull-requests
@AnEmortalKid
AnEmortalKid reviewed Sep 22, 2020
View changes
src/main/java/net/sf/jsqlparser/JSQLParserException.java

public JSQLParserException() {
super();
}

public JSQLParserException(String arg0) {
super(arg0);
public JSQLParserException(String message, Throwable cause) {

This comment has been minimized.

Sign in to view
@AnEmortalKid

AnEmortalKid Sep 22, 2020
Contributor

changed the class which means we should update the serial right?

This comment has been minimized.

Sign in to view
@gitmotte

gitmotte Sep 22, 2020
Author Contributor

ok, done

@AnEmortalKid
Copy link
Contributor

@AnEmortalKid AnEmortalKid commented Sep 22, 2020

Should this be split in chunks?

FeatureConfiguration class : common way for configurations of parser-features (supports Object-values - with convenience methods for boolean getAsBoolean, String getAsString)
Feature/FeatureSet classes : jsqlparser features which can be collected in featuresets

  1. extensible validation visitor framework
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Sep 22, 2020 •
edited

Should this be split in chunks?

No, the validation-framework depends on Feature/FeatureSet's, features could be parser-features like switching the ability for parsing the Square-Bracket Quotation (SQLServer-Feature) on or off - those Features are configured with FeatureConfiguration.
The most Feature's are currently only Validation-Features, the parser supports all of them, but we like to ensure a specific syntax (i.e. for postgresql database, see DatabaseType.POSTGRESQL) or we like to ensure sql-scripts do not change the DDL within your database (i.e. by validate against FeaturesAllowed.DML)
Therefore all Feature's can be validated (by extending the Validator-Visitors), but not all Feature's allow a parser-configuration.
And there are more validation-possibilities like

  • DatabaseMetaDataValidation (validate for names against a given database-connection)
  • AllowedTypesValidation (validate the model for correctness, i.e. when using the model-builder-pattern) (not supported within the validators currently)
  • ...
  • DatabaseType, Version: validate against features supported by one or multiple databases / versions of databases
  • FeaturesAllowed: validate against allowed features (like the sql GRANT, but without testing it against a database)
gitmotte added 14 commits Sep 22, 2020
@gitmotte
new serialVersionUID
Loading status checks…
29623ad
@gitmotte
add validation for NamedObject not existing
Loading status checks…
d455cbb
@gitmotte
need table/view reference to validate column names
8a79a08
@gitmotte
fix typo
Loading status checks…
3714a2c
@gitmotte
fix errormessage (Arrays.toString(types))
63a7896
@gitmotte
add trigger, alias
Loading status checks…
241ab00 
return null, instead of throwing exception, if not found
@gitmotte
extract NamesLookup to own file (jdk-bug enum inner classes)
Loading status checks…
9657d05
@gitmotte
fix name-check AlterOperation.ALTER
Loading status checks…
907cda7
@gitmotte
fix error message
c9030b2
@gitmotte
remove methods not needed (they only delegate to ValidationContext)
6257b66
@gitmotte
add tests - validate metadata
d2bc01f
@gitmotte
fix compile error
Loading status checks…
5f8ff53
@gitmotte
fix columnExists check - depending on the statement the prefix is an
34cf7b9 
alias, a table/view or it has no prefix (need to lookup within all
related tables/views)
@gitmotte
fix javadoc warnings
Loading status checks…
f86eed8
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Sep 30, 2020

it's ready to merge now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnEmortalKid AnEmortalKid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@gitmotte @coveralls @AnEmortalKid
You can’t perform that action at this time.