Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
feat(user): split repositories list by type #739
Conversation
|
This is great @Arjun-sna ! I left you some remarks, my biggest concern being that the button group won't play nice with longer texts when using translations .. not really sure how to properly handle it :/ |
| 'user.repositoryList.memberReposButton', | ||
| locale | ||
| ), | ||
| ] |
machour
Feb 26, 2018
Member
Could this be computed outside the JSX and condensed?
const buttons = ['common','buttons'];
if (authUser.login === currentuser.login) {
buttons.push('other');
buttons.push('buttons');
}
Could this be computed outside the JSX and condensed?
const buttons = ['common','buttons'];
if (authUser.login === currentuser.login) {
buttons.push('other');
buttons.push('buttons');
}
| headerRight: ( | ||
| <Icon | ||
| name="search" | ||
| color={colors.primaryDark} |
machour
Feb 26, 2018
Member
personal taste: maybe greyDark would be better (in find the loop "too black")
personal taste: maybe greyDark would be better (in find the loop "too black")
| </SearchContainer> | ||
| </SearchBarWrapper> | ||
| ) : ( | ||
| <StyledButtonGroup |
machour
Feb 26, 2018
Member
English labels fits right in, but I'm afraid other translations won't play as nice.. 🤔
Try with french labels for example: "Tous, Propriétaire, Membre, Privé, Public"
English labels fits right in, but I'm afraid other translations won't play as nice..
Try with french labels for example: "Tous, Propriétaire, Membre, Privé, Public"
machour
changed the title
|
(In order to fix the Travis build, you have to add the english sentences in all the translations files. |
add default texts for repo type titles for other languages
|
@machour tried to fix longer texts with |
Screenshots Auth user
Screenshots user
Description
Added categories to repo list screen