Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added roman to integer conversion #172
Closed
Conversation
conversions/roman_to_integer.go
Outdated
| return total | ||
| } | ||
|
|
||
| func main() { |
nomisrevol
Oct 1, 2020
Collaborator
Remove main function and create a new test file instead.
Remove main function and create a new test file instead.
Navid2zp
Oct 1, 2020
Author
Contributor
The main function is removed and test files created.
The main function is removed and test files created.
| name string | ||
| } | ||
|
|
||
| var romanToIntegerTests = []romanToIntegerConversionTest{ |
nomisrevol
Oct 1, 2020
Collaborator
Move the testcases inside of the test file. We do not need it to separated in a standalone file.
Move the testcases inside of the test file. We do not need it to separated in a standalone file.
Navid2zp
Oct 1, 2020
Author
Contributor
Should I rename the test file to roman_to_integer_test.go or you want all the tests in one file like the way it is now?
Should I rename the test file to roman_to_integer_test.go or you want all the tests in one file like the way it is now?
|
|
||
| //END TESTS | ||
|
|
||
| //BEGIN BENCHMARKS |
nomisrevol
Oct 1, 2020
Collaborator
No need to have benchmark for a single implementation, please remove all unnecessary like BEGIN TESTS or END TESTS also.
No need to have benchmark for a single implementation, please remove all unnecessary like BEGIN TESTS or END TESTS also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Added roman to integer conversion and it's file link to DIRECTORY.md