The Wayback Machine - https://web.archive.org/web/20201215052845/https://github.com/github/VisualStudio/pull/1561
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spike] Add `View > Team Explorer` button to `GitHub` pane command bar #1561

Closed
wants to merge 2 commits into from
Closed

[spike] Add `View > Team Explorer` button to `GitHub` pane command bar #1561

wants to merge 2 commits into from

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 23, 2018 •
edited

This PR

  • Add the View > Team Explorer button the the GitHub pane's command bar

image

  • Use standard Backwards, Forwards, OpenWebSite, Refresh and StatusHelp monikers for GitHub command bar (found in KnownImageIds.vsct) Moved to #1876

  • Add view GitHub pane button to Team Explorer command bar

image

Mentioned by @sguthals in #1558

I can go back to the list view of PRs or open a browser window into GitHub, but I can't get back to the Team Explorer home. To get there, I have to go down to the bottom and click on the Team Explorer tab.

Todo

  • An easy way to navigate back to the GitHub pane

When you try this functionality, the question quickly becomes; how do I get back to the GitHub pane.

I don't know if it's possible to add buttons to the Team Explorer command bar. If it was, the symmetry would make it feel pretty natural and discoverable. It would also let users easily return to GitHub from the Team Explorer - Changes view (which is a common workflow).

An alternative would be to allow users to click on the icon below GitHub to return to the GitHub pane. This wouldn't be available on the Team Explorer - Changes view, so users would need to navigate back via Home.

image

  • There are built in monikers for Forwards, Backwards and (maybe) Home that we could use.

This would make it consistent wit the Team Explorer and Solution Explorer tool bars:
image

Related
@jcansdale
Add view Team Explorer to GitHub pane command bar
Loading status checks…
db0b285
@jcansdale jcansdale changed the title Add view Team Explorer to GitHub pane command bar Add `View > Team Explorer` button to `GitHub` pane command bar Mar 23, 2018
@jcansdale
Copy link
Collaborator Author

@jcansdale jcansdale commented Mar 23, 2018 •
edited

There's an extension for viewing monikers here:
https://github.com/madskristensen/KnownMonikersExplorer

Here is the Backwards image moniker.

image

You can find the rest described here:

image

*Note, the name doesn't quite match in this case (Backwards vs Backward) 😕 *
@jcansdale jcansdale requested review from sguthals and donokuda Mar 23, 2018
@sguthals
Copy link
Contributor

@sguthals sguthals commented Mar 29, 2018

Thanks @jcansdale for this! I want to punt it to our first 3+1 week to get more feedback. I like this approach if it's the problem we want to solve. We may want to be solving a different problem though - making it less streamlined.
@sguthals
sguthals reviewed May 22, 2018
View changes
src/GitHub.VisualStudio/GitHub.VisualStudio.vsct Outdated
@@ -3,6 +3,9 @@
xmlns="http://schemas.microsoft.com/VisualStudio/2005-10-18/CommandTable"
xmlns:xs="http://www.w3.org/2001/XMLSchema">

<!-- Import the standard ImageCatalogGuid monikers -->

This comment has been minimized.

Sign in to view
@sguthals

sguthals May 22, 2018
Contributor

LGTM

This comment has been minimized.

Sign in to view
@jcansdale

jcansdale May 24, 2018
Author Collaborator

@sguthals Woot! 🎉 😜

@sguthals
sguthals reviewed May 22, 2018
View changes
src/GitHub.VisualStudio/GitHub.VisualStudio.vsct Outdated
@@ -3,6 +3,9 @@
xmlns="http://schemas.microsoft.com/VisualStudio/2005-10-18/CommandTable"
xmlns:xs="http://www.w3.org/2001/XMLSchema">

<!-- Import the standard ImageCatalogGuid monikers -->
<Include href="KnownImageIds.vsct"/>

This comment has been minimized.

Sign in to view
@sguthals

sguthals May 22, 2018
Contributor

Starting review

@sguthals
sguthals approved these changes May 22, 2018
View changes
Copy link
Contributor

@sguthals sguthals left a comment

Testing
@sguthals
sguthals approved these changes May 22, 2018
View changes
Copy link
Contributor

@sguthals sguthals left a comment

Testing
@sguthals
sguthals suggested changes May 22, 2018
View changes
Copy link
Contributor

@sguthals sguthals left a comment

Test
This was referenced Aug 23, 2018
Merged
Merged
@jcansdale
[wip] Add GitHub to Team Explorer command bar
Loading status checks…
7f0f3dd
@jcansdale jcansdale force-pushed the fixes/1558-toolbar-navigation-between-panes branch from 7c43b4a to 7f0f3dd Aug 23, 2018
@jcansdale
Copy link
Collaborator Author

@jcansdale jcansdale commented Aug 23, 2018

I've extracted the following commits to separate PRs (they shouldn't have been included in this PR):

  • #1877 Use OpenWebSite image for View/Open on GitHub
  • #1876 Use standard image monikers for GitHub pane
@jcansdale jcansdale changed the title Add `View > Team Explorer` button to `GitHub` pane command bar [wip] Add `View > Team Explorer` button to `GitHub` pane command bar Aug 23, 2018
@jcansdale jcansdale changed the title [wip] Add `View > Team Explorer` button to `GitHub` pane command bar [spike] Add `View > Team Explorer` button to `GitHub` pane command bar Aug 23, 2018
@jcansdale jcansdale closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguthals sguthals

@donokuda donokuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jcansdale @sguthals
You can’t perform that action at this time.