bpo-41110: Fixed lib2to3 reporting some unchanged files as needing modification #21296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWhetter
force-pushed
the
fix-issue-41110
branch
from
042558c to
b87c9a5
Compare
|
Closed under bpo-45544. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes prevents lib2to3 fixers from changing the tree unnecessarily, which results in no visible diff and the file still being reported as needing modifications.
This partially addresses an issue in
python-modernizewhere a non-zero exit code is returned even when no changes to files need to be made: PyCQA/modernize#161Given that lib2to3 is on its way out, I don't know if this should be fixed in 3.8 and 3.9 only?
https://bugs.python.org/issue41110