angular/angular

1 Pull request merged by 1 person

• Merged #29381 revert: refactor(ivy): Update query-related comments (#29342) Mar 18, 2019

35 Pull requests proposed by 24 people

• Proposed #29339 refactor(ivy): add new view container api Mar 15, 2019
• Proposed #29340 Insert after comment Mar 15, 2019
• Proposed #29345 docs: fixed issue with field names in reactive forms guide Mar 15, 2019
• Proposed #29348 refactor(ivy): Add i18n create op codes debug info Mar 15, 2019
• Proposed #29354 fix(build): Merge script should fail if there are fixups after merge Mar 16, 2019
• Proposed #29355 refactor: use new Http library in playground Mar 17, 2019
• Proposed #29356 feat: move legacy Http library out of platform-server w/ compat [POC] Mar 17, 2019
• Proposed #29358 not need two enter separation Mar 17, 2019
• Proposed #29372 build: update to TypeScript 3.4 Mar 18, 2019
• Proposed #29376 docs: add project structure for library Mar 18, 2019
• Proposed #29380 Perf logging & Incremental Compilation Mar 18, 2019
• Proposed #29390 refactor: uniformly access all index sigs with index access. Mar 19, 2019
• Proposed #29392 fix(router): support NgFactory promise in loadChildren typings Mar 19, 2019
• Proposed #29404 fix(ivy): avoid remote scoping if it's not actually required Mar 19, 2019
• Proposed #29408 feat: remove @angular/http dependency from @angular/platform-server Mar 20, 2019
• Proposed #29414 fix(ivy): ViewContainerRef.destroy should properly clean the DOM Mar 20, 2019
• Proposed #29432 docs: add Bonnie to GDE page Mar 20, 2019
• Proposed #29433 docs: improve glossary for entry-point Mar 20, 2019
• Proposed #29435 docs: add TypeScript team members to aio Mar 20, 2019
• Proposed #29438 Debug node query via dom issues Mar 21, 2019
• Proposed #29446 docs: fix typo in rxjs guide example Mar 21, 2019
• Proposed #29449 fix(bazel): allow ng_module users to set createExternalSymbolFactoryR… Mar 21, 2019
• Proposed #29453 fix(ivy): ngtsc is unable to detect flat module entry-point on windows Mar 21, 2019
• Proposed #29459 Create external symbol factory reexports Mar 22, 2019
• Proposed #29466 refactor(upgrade): use Bazel packages to avoid symlinks in the source Mar 22, 2019
• Proposed #29470 fix(ivy): avoid type coercion in binding-related instruction asserts Mar 22, 2019
• Proposed #29471 docs: fix broken changelog link Mar 22, 2019
• Proposed #29472 Update hero.service.1.ts Mar 22, 2019
• Proposed #29473 docs(forms): properly convert number to string for formControlName input Mar 22, 2019
• Proposed #29474 docs(core): close tags in example Mar 22, 2019
• Proposed #29475 docs: fix link in codefresh readme file Mar 22, 2019
• Proposed #29478 ci: add `.codefresh/` to the `fw-dev-infra` group Mar 22, 2019
• Proposed #29479 Map deprecated http APIs to closest APIs in http/commom package Mar 22, 2019
• Proposed #29480 fix(ivy): DebugNode.query should query nodes in the logical tree Mar 22, 2019
• Proposed #29481 typo in example caused tutorial to break; void return type was missing Mar 22, 2019

49 Issues closed by 12 people

• Closed #29460 Snyk Vulnerability: Command Injection through `shelljs` Mar 22, 2019
• Closed #29461 Service inside service Mar 22, 2019
• Closed #29457 Can't the project be opened? Mar 22, 2019
• Closed #29458 172.217.161.176:443 Not accessible?? Mar 22, 2019
• Closed #29456 Can't open this project?????? Mar 22, 2019
• Closed #29455 Can't outsiders open this project?????? Mar 22, 2019
• Closed #24153 Drop the "Coding conventions" section from the style guide Mar 21, 2019
• Closed #28579 saucelabs tunnel is not established within 120 seconds on CI Mar 21, 2019
• Closed #28940 Fix CircleCI turnaround time regression via test parallelization Mar 21, 2019
• Closed #29321 "fit" / "fdescribe" no longer working for running bazel tests Mar 21, 2019
• Closed #29451 0501465368 Mar 21, 2019
• Closed #29450 https://www.facebook.com/profile.php?id=100028240161630 Mar 21, 2019
• Closed #29448 ViewContainerRef.createComponent not inserting component into element Mar 21, 2019
• Closed #21388 bug(ServiceWorker): multiple apps with ServiceWorker on one domain Mar 21, 2019
• Closed #29132 ci/circleci: integration_test flake: fails with "No usable sandbox! Update your kernel" Mar 21, 2019
• Closed #29427 Bazel clean required between test runs Mar 21, 2019
• Closed #29420 TypeError: Cannot read property 'visit' of undefined Mar 21, 2019
• Closed #29425 "this" binding in template causes massive lag Mar 21, 2019
• Closed #29400 ngcc: produces wrong d.ts files for generic types (pipes) Mar 20, 2019
• Closed #27157 Angular Universal Mar 20, 2019
• Closed #27187 Prefetch Component Data Missing file Mar 20, 2019
• Closed #27224 Scripts for running an universal app should be added to package.json instead of angular.json Mar 20, 2019
• Closed #27566 Server side rendering documentation issue in Step 5: Pack and run the app on the server S Mar 20, 2019
• Closed #27866 catchError of sample “https://angular.io/tutorial/toh-pt6” it's not working Mar 20, 2019
• Closed #28043 The `InputDecorator` (`@Input`) api description is incorrect Mar 20, 2019
• Closed #28135 Missing documentation for viewencapsulation.native Mar 20, 2019
• Closed #28310 docs: ViewEncapsulation.ShadowDom option is not available in component doc Mar 20, 2019
• Closed #28311 Typo of "browserslist" in file structure and build guides Mar 20, 2019
• Closed #29278 Animations getAnimationStyle return undefined in angular 7.x with old browsers Mar 20, 2019
• Closed #29415 New feature to identify an element from X and Y coordinates Mar 20, 2019
• Closed #29410 Multiple Independent Instance of Same Component Mar 20, 2019
• Closed #29369 Disable Html5 Attributes Validation Mar 19, 2019
• Closed #29379 it seems that the alias "as" no longer works in the build Mar 19, 2019
• Closed #29352 ERROR in node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'. Mar 19, 2019
• Closed #29123 ngc generates commonjs incompatible with bazel ts_devserver Mar 19, 2019
• Closed #28317 Bazel: Unable to generate new app with bazel collection. Mar 19, 2019
• Closed #29231 infinite loop in the tokenizer Mar 19, 2019
• Closed #29368 Why service worker show notification if only user on website Mar 18, 2019
• Closed #29359 Service worker - What about clients object? Mar 18, 2019
• Closed #29365 error in production build when loading js file Mar 18, 2019
• Closed #29357 Angular Language Support and Django Conflict Mar 18, 2019
• Closed #29366 can't able to clone a viewRef from one container to another container Mar 18, 2019
• Closed #29367 When I use ng generate component, I'd like to get a scss file instead of a sass file. Mar 18, 2019
• Closed #29364 Partial view encapsulation Mar 18, 2019
• Closed #29325 why the files of vendor.bundle.js are different when compile the same project? Mar 16, 2019
• Closed #29341 @angular-builders/custom-webpack npm source link 404 Mar 16, 2019
• Closed #29333 Angular and Polyfills no longer working on IE 11 Mar 16, 2019
• Closed #29349 Docs two way binding coun't work Mar 16, 2019
• Closed #17346 [Feature Request] Automatic injection of the BrowserModule Mar 16, 2019

26 Issues created by 25 people

• Opened #29477 Routing not working as Expected Mar 22, 2019
• Opened #29469 Remove private properties/methods from publicApi interfaces Mar 22, 2019
• Opened #29468 docs(aio) incorrect information in ngmodule-faq.md Mar 22, 2019
• Opened #29467 QueryList<T>.get(index) Mar 22, 2019
• Opened #29465 Cannot use router-outlet twice in desktop-and-mobile-template Mar 22, 2019
• Opened #29463 Issue with animations not working correctly on IE/Edge Mar 22, 2019
• Opened #29454 Not possible to generate a correct ngfactory import for an npm package using summary files Mar 22, 2019
• Opened #29452 Angular HMR docs are out of date Mar 21, 2019
• Opened #29445 Protractor: Angular app uses hash routing. e2e tests do not navigate correctly. Mar 21, 2019
• Opened #29441 Failed to find exported name of node Mar 21, 2019
• Opened #29439 Easy way to animate change of bound values Mar 21, 2019
• Opened #29428 [Router]: Catch-All Wildcard Route Not Lazy Loaded Mar 20, 2019
• Opened #29421 ExpressionChangedAfterItHasBeenCheckedError, ngForm inside ng-template or structural directives and bindings to this form outside of ngTemplate : change detection works incorrectly Mar 20, 2019
• Opened #29413 Get list of all injected or injectable services of a module or component Mar 20, 2019
• Opened #29397 [Router] Allow scrollOffset of ExtraOptions to be an injectable token and allow the return value to be an Observable Mar 19, 2019
• Opened #29395 Detect ng-content changes Mar 19, 2019
• Opened #29393 Tutorial "Tour of Heros" css styles ".heroes .text" not used Mar 19, 2019
• Opened #29391 Route Snapshot fragment is sometimes null and sometimes undefined Mar 19, 2019
• Opened #29389 The state passed to router.navigate is lost when doing multiple navigations Mar 19, 2019
• Opened #29374 Routing: canActivate is not created in --prod when using concat Mar 18, 2019
• Opened #29371 [Animations] toggle state with `display: 'none'` doesn't work on Safari Mar 18, 2019
• Opened #29363 [Ivy Mode] "ng build" and "ng serve" error under Ivy mode in angular 8 beta Mar 18, 2019
• Opened #29362 Ivy, ngcc: InlineSVGModule.forRoot() yields "is not a reference" Mar 17, 2019
• Opened #29361 Ivy: Unable to write a reference Mar 17, 2019
• Opened #29351 Injector#get is typed incorrectly Mar 16, 2019
• Opened #29337 Build guide could be more clear about where to create proxy.conf.json Mar 15, 2019

92 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

• 47 new comments Open #28700 docs: clarify hierarchical injectors Mar 21, 2019
• 11 new comments Open #16848 feat(upgrade): provide test helpers for wiring up injectors (WIP) Mar 22, 2019
• 10 new comments Open #28530 ci(docs-infra): run with ivy Mar 21, 2019
• 8 new comments Open #29289 Add API doc for pipes/i18n config Mar 21, 2019
• 6 new comments Open #28337 fix(upgrade): catch expection during digest Mar 18, 2019
• 5 new comments Open #24680 UpgradeModule: Exception in $digest breaks change propagation Mar 21, 2019
• 5 new comments Open #26002 feat(service-worker): expose RegistrationOptions token to allow for runtime configuration Mar 20, 2019
• 5 new comments Open #29259 update examples region to match the description in docs Mar 22, 2019
• 4 new comments Open #27684 WIP: getting started Mar 21, 2019
• 4 new comments Open #29142 docs: add globegitter to Angular collaborators Mar 22, 2019
• 4 new comments Open #29206 docs: add note about ngModel usage in structural directives guide Mar 22, 2019
• 4 new comments Open #29295 feat(core): Add "AbstractType<T>" interface Mar 19, 2019
• 3 new comments Open #23609 Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect Mar 15, 2019
• 3 new comments Open #29225 Add file structure section to Creating Libraries Mar 19, 2019
• 3 new comments Open #29149 Support for providing ngFor trackBy function through DI Mar 20, 2019
• 3 new comments Open #29213 animations guide: incorrect links to forms groups instead of animations group Mar 21, 2019
• 3 new comments Open #21842 feat(service-worker): add option to config when to register sw Mar 20, 2019
• 3 new comments Open #28219 build: upgrade zone.js to 0.9.0 Mar 22, 2019
• 3 new comments Open #28476 docs: add custom-element ref to library overview Mar 20, 2019
• 2 new comments Open #21167 Can log activity of Change Detection sub-system? Mar 17, 2019
• 2 new comments Open #20511 HttpClient does not set X-XSRF-Token on Http Post Mar 18, 2019
• 2 new comments Open #13586 Deactivation Guard breaks the routing history Mar 19, 2019
• 2 new comments Open #21751 Angular @ContentChildren of an recursive ng-template Mar 19, 2019
• 2 new comments Open #29241 Add Official Schematics documentation Mar 19, 2019
• 2 new comments Open #29099 Anchor scrolling only works first time it is clicked and not on subsequent clicks. Mar 20, 2019
• 2 new comments Open #28578 AngularJS files fail to load in ngUpgrade tests on CI Mar 21, 2019
• 2 new comments Open #26963 Glossary update: add architect terms and xrefs to new pages Mar 20, 2019
• 2 new comments Open #27272 Add schematic details and links to config page Mar 20, 2019
• 2 new comments Open #28214 Add asset configuration details Mar 20, 2019
• 2 new comments Open #28217 Update deployment guide with serve-from-disk info from CLI story Mar 20, 2019
• 2 new comments Open #28434 docs: take out coremodule references Mar 22, 2019
• 2 new comments Open #28492 Add Universal terms to glossary Mar 20, 2019
• 2 new comments Open #28571 docs: clarify Tour of Heroes, esp. Routing step Mar 22, 2019
• 2 new comments Open #28577 [WIP]docs: add documentation for ngNonBindable Mar 22, 2019
• 2 new comments Open #28685 fix(ivy): don't load factories when using Ivy Mar 19, 2019
• 2 new comments Open #28825 feat(docs-infra): suggest localized version based on browser language Mar 21, 2019
• 2 new comments Open #29232 fix(compiler): inherit param types when class has a constructor which… Mar 21, 2019
• 2 new comments Open #29299 refactor(ivy): move di tests for Attribute and special tokens to acceptance Mar 20, 2019
• 1 new comment Open #20005 viewProviders only available at depth of 1 Mar 15, 2019
• 1 new comment Open #16211 canActivate=>false can result in blank screen/dead link Mar 16, 2019
• 1 new comment Open #28643 [Ivy] @ViewChild doesn't read me ElementRef Mar 16, 2019
• 1 new comment Open #29114 [Ivy] App crashes at runtime with NgRx 7.x Mar 16, 2019
• 1 new comment Open #24598 fullTemplateTypeCheck doesn't seem to work with async pipe and ngIf Mar 18, 2019
• 1 new comment Open #17766 Feature: @Directive should support styles and styleUrls properties Mar 18, 2019
• 1 new comment Open #23657 ExpressionChangedAfterItHasBeenCheckedError with dynamic validators in a template driven composite form control Mar 18, 2019
• 1 new comment Open #15088 APP_INITIALIZER should also work with observables Mar 18, 2019
• 1 new comment Open #24563 ContentChild's update triggers ExpressionChangedAfterItHasBeenCheckedError when child created with ngFor Mar 19, 2019
• 1 new comment Open #11405 i18n: Able to use translation strings outside a template Mar 19, 2019
• 1 new comment Open #22509 Bug router angular v5.2.4+ with cordova (BrowserAnimationsModule bug) Mar 19, 2019
• 1 new comment Open #29327 [Ivy] Error: Unknown node type: function LiteralMap Mar 19, 2019
• 1 new comment Open #21800 BUG: ViewChild property is set before OnInit Mar 19, 2019
• 1 new comment Open #21456 Cannot build 5.2 with bazel Mar 19, 2019
• 1 new comment Open #19747 [Proposal] Initial / Original value API for AbstractControl Mar 19, 2019
• 1 new comment Open #28108 'history.state' object is getting lost when navigate using back/forward buttons Mar 20, 2019
• 1 new comment Open #14842 ContentChildren doesn't get children created with NgTemplateOutlet Mar 20, 2019
• 1 new comment Open #9426 Router: Feature Request: default 'router-link-active' class attachment (old router behaviour) Mar 20, 2019
• 1 new comment Open #13461 FormControl.setValidators...why is there no getValidators? Mar 20, 2019
• 1 new comment Open #24069 Expose '_loadedConfig' in a public way. Mar 20, 2019
• 1 new comment Open #23484 Allow validateOn and invalidateOn, in addition to updateOn for AbstractControl Mar 20, 2019
• 1 new comment Open #12088 Load a component in a route depending on an asynchronous condition Mar 20, 2019
• 1 new comment Open #28887 Router.navigate url with slashes error Mar 21, 2019
• 1 new comment Open #21191 feat(service-worker): Support ignoring specific URLs (e.g. for AJAX progress listener, video streaming, range requests, Firebase uploads) Mar 21, 2019
• 1 new comment Open #12540 Number input fires valueChanges twice Mar 21, 2019
• 1 new comment Open #27804 DEV mode change detection - Show warning if object reference changes in subsequent check Mar 21, 2019
• 1 new comment Open #6827 Custom elements that extends existing elements does not upgrade in template on Chrome Mar 21, 2019
• 1 new comment Open #29297 Please consider adding Angular-Bootstrap-Boilerplate to /resources Mar 21, 2019
• 1 new comment Open #15741 FormGroup reset() doesn't reset custom form control Mar 22, 2019
• 1 new comment Open #24227 Angular 6 - ServiceWorker not requesting gzipped content Mar 22, 2019
• 1 new comment Open #27038 feat: remove @angular/http Mar 17, 2019
• 1 new comment Open #27475 docs: add a link to 'reactive forms' section Mar 20, 2019
• 1 new comment Open #28238 docs: clarify when polyfills are included with JIT compilation in browser support Mar 20, 2019
• 1 new comment Open #28291 Docs: add info regarding custom pipes Mar 20, 2019
• 1 new comment Open #29048 docs: update developer guide for testing and IntelliJ Mar 22, 2019
• 1 new comment Open #29290 fix(core): Deprecate TestBed.get(...):any Mar 21, 2019
• 0 new comments Open #25633 "{ providedIn: 'root' }" does not instantiate services as documented Mar 15, 2019
• 0 new comments Open #29205 Make wording in the directives more inclusive Mar 16, 2019
• 0 new comments Open #20600 Property binding ignores @Input types Mar 17, 2019
• 0 new comments Open #21115 onSameUrlNavigation doesn't re-load routed components Mar 18, 2019
• 0 new comments Open #21560 Remove `System.import()` usage in favor of `import()` Mar 18, 2019
• 0 new comments Open #9343 Allow Custom CSS Variables in [ngStyle] Mar 20, 2019
• 0 new comments Open #29330 `providedIn: null` has the same effect as `providedIn: 'root'` Mar 21, 2019
• 0 new comments Open #28611 "Too long with no output" error in integration_test job Mar 21, 2019
• 0 new comments Open #28601 ci: Global approvers list in CODEOWNERS doesn't seem to work Mar 21, 2019
• 0 new comments Open #26291 docs(docs-infra): standardize tables' markup Mar 20, 2019
• 0 new comments Open #28117 feat: remove deprecated DOCUMENT token from platform-browser Mar 16, 2019
• 0 new comments Open #28507 add details to HttpUrlEncodingCodec API description Mar 20, 2019
• 0 new comments Open #29119 fix(ivy): ngcc - properly handle aliased class expressions Mar 19, 2019
• 0 new comments Open #29288 docs: no network request for performance strategy Mar 19, 2019
• 0 new comments Open #29322 Update router.ts Mar 19, 2019
• 0 new comments Open #29329 test: add integration test for side effects Mar 19, 2019
• 0 new comments Open #29335 Form control directive clean up Mar 19, 2019
• 0 new comments Open #29336 DO NOT REVIEW, TESTING feat(bazel): use new rbe_autoconfig() and new container. Mar 20, 2019