The Wayback Machine - https://web.archive.org/web/20211020045205/https://github.com/angular/angular/pull/29392
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): support NgFactory promise in loadChildren typings #29392

Closed
wants to merge 1 commit into from
Closed

fix(router): support NgFactory promise in loadChildren typings #29392

wants to merge 1 commit into from

Conversation

@filipesilva
Copy link
Member

@filipesilva filipesilva commented Mar 19, 2019 •
edited

The router loadChildren property already supports a promise that returnes a NgModuleFactory, but the typings cause the compilation to fail.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.

What is the new behavior?

Typings contain the correct supported types.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@filipesilva filipesilva requested a review from as a code owner Mar 19, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Mar 19, 2019

You can preview b1a3cdb at https://pr29392-b1a3cdb.ngbuilds.io/.

@filipesilva
fix(router): support NgFactory promise in loadChildren typings
2e2a8aa 
The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.
@filipesilva filipesilva force-pushed the loadchildren-factory-promise branch from b1a3cdb to 2e2a8aa Mar 19, 2019
@filipesilva filipesilva requested a review from as a code owner Mar 19, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Mar 19, 2019

You can preview 2e2a8aa at https://pr29392-2e2a8aa.ngbuilds.io/.

@filipesilva filipesilva mentioned this pull request Mar 19, 2019
Merged
@filipesilva filipesilva mentioned this pull request Mar 19, 2019
Closed
14 tasks
@ngbot ngbot bot added this to the needsTriage milestone Mar 19, 2019
@filipesilva filipesilva requested a review from IgorMinar Mar 25, 2019
IgorMinar
IgorMinar approved these changes Mar 25, 2019
View changes
Copy link
Member

@IgorMinar IgorMinar left a comment

thanks!

@mhevery mhevery closed this in 26a8c59 Mar 25, 2019
@filipesilva filipesilva deleted the loadchildren-factory-promise branch Mar 26, 2019
wKoza added a commit to wKoza/angular that referenced this issue Apr 17, 2019
@filipesilva @wKoza
fix(router): support NgFactory promise in loadChildren typings (angul…
d4bf1c7 
…ar#29392)

The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.

PR Close angular#29392
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

@angular/fw-router fw-router

Assignees
No one assigned
Labels
action: merge cla: yes comp: router target: major
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@filipesilva @mary-poppins @IgorMinar @mhevery @googlebot