The Wayback Machine - https://web.archive.org/web/20190322181109/https://github.com/angular/angular/pull/29411
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix html tags in changelog #29411

Closed
wants to merge 1 commit into
base: master
from
+1 −1

Conversation

Reviewers

@gkalpak gkalpak

Assignees
No one assigned
Labels
PR action: merge PR target: master-only cla: yes comp: docs
Projects
None yet
Milestone
  needsTriage
4 participants
@macjohnny @gkalpak @matsko @googlebot
@macjohnny
Copy link
Contributor

macjohnny commented Mar 20, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

the tags are interpreted as html instead of being shown when viewing the changelog

Issue Number: N/A

What is the new behavior?

the tags are shown as code

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@macjohnny macjohnny requested a review from angular/fw-dev-infra as a code owner Mar 20, 2019

@googlebot googlebot added the cla: yes label Mar 20, 2019

@gkalpak gkalpak added PR action: cleanup comp: docs PR target: master & patch labels Mar 20, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2019

@gkalpak

gkalpak requested changes Mar 20, 2019
View changes

Copy link
Member

gkalpak left a comment

Thx!
Could you please change the commit message to docs: ...?

@macjohnny macjohnny force-pushed the macjohnny:patch-2 branch from 75c6e38 to c7ec4d3 Mar 20, 2019

@macjohnny

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

macjohnny commented Mar 20, 2019

@gkalpak I updated the commit message

@gkalpak gkalpak added PR action: merge and removed PR action: cleanup labels Mar 20, 2019

@gkalpak gkalpak changed the title docs(changelog): fix html tags in changelog docs: fix html tags in changelog Mar 20, 2019

@gkalpak

gkalpak approved these changes Mar 20, 2019
View changes

@macjohnny

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

macjohnny commented Mar 20, 2019 •
edited

@gkalpak the build error Error: The Angular Compiler requires TypeScript >=3.3.3333 and <3.4.0 but 3.1.6 was found instead. seems to be unrelated to this change
(https://circleci.com/gh/angular/angular/252446?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

@gkalpak gkalpak added the PR action: merge-assistance label Mar 20, 2019

@gkalpak

This comment has been minimized.

Sign in to view
Copy link
Member

gkalpak commented Mar 20, 2019 •
edited

merge-assistance: The Material tests failure is unrelated to this PR.
@macjohnny

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

macjohnny commented Mar 20, 2019

@gkalpak all CI tests pass

@gkalpak gkalpak removed the PR action: merge-assistance label Mar 20, 2019

@matsko

This comment has been minimized.

Sign in to view
Copy link
Member

matsko commented Mar 20, 2019

@macjohnny please rebase.

@matsko matsko added PR target: master-only PR target: master & patch and removed PR target: master & patch PR target: master-only labels Mar 20, 2019

@matsko

This comment has been minimized.

Sign in to view
Copy link
Member

matsko commented Mar 20, 2019

Also get rid of the 2nd commit (the merge one).

@matsko matsko removed the PR action: merge label Mar 20, 2019

@macjohnny
docs: fix html tags in changelog
Loading status checks…
ba5ab5c

@macjohnny macjohnny force-pushed the macjohnny:patch-2 branch from 2c71d78 to ba5ab5c Mar 21, 2019

@macjohnny

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

macjohnny commented Mar 21, 2019

@gkalpak @matsko I rebased the PR. now it has only one commit with the correct commit message, and the tests pass, so it should be good to go. sorry for the inconveniences

@matsko matsko added PR action: merge PR target: master-only labels Mar 21, 2019

@matsko matsko removed the PR target: master & patch label Mar 21, 2019

@matsko matsko closed this in 41737bb Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.