There are more changes in #1714 that seem unnecessary or not really clear:

• https://github.com/github/VisualStudio/pull/1714/files#diff-44ee993861822d4f52c2cc353f059cffR482 is odd: if the localization falls back to the neutral resource, why have a GitHub.VisualStudio.en-US.vsct and a GitHub.VisualStudio.vsct if the second is empty? If the point is to have localized strings in the menus, than anything that doesn't have strings should probably be in the non localized vsct, otherwise adding things is going to be double the pain.

• https://github.com/github/VisualStudio/pull/1714/files#diff-930c4aa2d9b0f5a330b6b5deab76a257L16 is not a good change - every project needs to define the neutral resources language, which is why it was on SolutionInfo.cs in the first place, so we might want to revert all the SolutionInfo.cs and AssemblyInfo.cs changes in #1714

• src/GitHub.VisualStudio/VSPackage.zh-Hans.resx doesn't have any localized strings so it probably doesn't need to be there.

• Why is there a src/GitHub.VisualStudio.UI/Resources.resx and a src/GitHub.VisualStudio.UI/Resources.en-US.resx? They both contain localizable strings and look to be copies of each other? Both are embedded but only one is getting compiled.

• GitHub.VisualStudio.en-US.vsct only have string , but GitHub.VisualStudio.vsct not any string , Other languages refer to this file !
• [assembly: NeutralResourcesLanguage("en-US")] This sentence can fall back to English！
• src/GitHub.VisualStudio/VSPackage.zh-Hans.resx Should use Chinese, but the language has not yet organized very well, so, for the time being is still English instead.

Sorry, I can understand English, but I can only rely on Google translation to express my ideas.