don't apply urlize to @a@b#1870
Closed
nabijaczleweli wants to merge 1 commit intopallets:mainfrom
nabijaczleweli:main
Closed
don't apply urlize to @a@b#1870nabijaczleweli wants to merge 1 commit intopallets:mainfrom nabijaczleweli:main
urlize to @a@b#1870nabijaczleweli wants to merge 1 commit intopallets:mainfrom
nabijaczleweli:main
Conversation
This chases https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3Clelaromu5mjgibe6jywrc2iwoikon2piwo2h34rcsyjhbyge5y%40fdtowru7pv5e%3E and thus https://101010.pl/@[email protected]/110742090990556162 It's a common way to spell both "a user of some site" but also universal in the mastodon world. None of these are valid e-mail addresses (especially since urlize makes @eater@cijber.social into <a href="mailto:@eater@cijber.social">@eater@cijber.social</a> which straight-up just isn't really a valid e-mail address anyway).
This comment was marked as off-topic.
This comment was marked as off-topic.
davidism
changed the title
urlize to @a@b
Member
|
It looks like you didn't enable "allow pushes from maintainers" for this PR, so I can't update it to prepare for merge. I'll open a new PR to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This chases https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3Clelaromu5mjgibe6jywrc2iwoikon2piwo2h34rcsyjhbyge5y%40fdtowru7pv5e%3E and thus https://101010.pl/@[email protected]/110742090990556162
It's a common way to spell both "a user of some site" but also universal in the mastodon world. None of these are valid e-mail addresses (especially since urlize makes
@[email protected]into<a href="mailto:@[email protected]">@[email protected]</a>which straight-up just isn't really a valid e-mail address anyway).Checklist:
@a@bisn't really a valid email anyway and it was erroneously acceptedCHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs. – Likewisepre-commithooks and fix any issues.pytestandtox, no tests failed.