-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
DOC: Improve widgets API documentation #30939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
doc/api/widgets_api.rst
Outdated
| LassoSelector | ||
| PolygonSelector | ||
| SpanSelector | ||
| RadioButtons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Radio buttons are related to check buttons, so I would put this after them.
| :show-inheritance: | ||
| Widget | ||
| AxesWidget | ||
| MultiCursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also unsure why this isn't near plain Cursor?
- Structure the page into widgets and helpers. This requires explicit listing of the classes, but is bearable as we don't often add new classes - Limit the inheritance diagram to the Widget subclasses instead of also showning the helper classes there - Add documentation for `_SelectorWidget`. It's important to understand its subclasses. This also results in correctly showing the selector inheritance in the inheritance diagram
575891f to
2da7bc2
Compare
|
@QuLogic I initially just took over the order the classes were in in the code. Now I've completely reordered to:
|
The current widgets API documentation is quite messy.
This PR improves this by:
_SelectorWidget. It's important to understand its subclasses. This also results in correctly showing the selector inheritance in the inheritance diagram