-
Notifications
You must be signed in to change notification settings - Fork 1.9k
C++ / JS / python: Be consistent in TRAP sections #20957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
igfoo
wants to merge
16
commits into
github:main
Choose a base branch
from
igfoo:igfoo/consistent-metadata-and-overlay-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
C++ / JS / python: Be consistent in TRAP sections #20957
igfoo
wants to merge
16
commits into
github:main
from
igfoo:igfoo/consistent-metadata-and-overlay-support
+40,439
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6479657 to
0419413
Compare
We now use the shared "Overlay support" and "Database metadata".
0419413 to
997fe29
Compare
We now use the shared "Overlay support" and "Database metadata".
We now use the shared "Overlay support" and "Database metadata".
We now use the shared "Overlay support" and "Database metadata".
997fe29 to
c429e00
Compare
Member
Author
|
ql-for-ql failures seems to be unrelated to this PR, e.g. https://github.com/github/codeql/actions/runs/20967345319/job/60261261271 fails the same way on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
and
sections consistent between the languages.